Re: [PATCH v3 5/6] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64

Stefano Stabellini
2013-06-05T12:38:33Z

On Wed, 5 Jun 2013, Ian Campbell wrote:
> On Wed, 2013-06-05 at 13:15 +0100, Stefano Stabellini wrote:
> > Introduce CONFIG_XEN and the implementation of hypercall.S (that is
> > the only ARMv8 specific code in Xen support for ARM).
> >
> > Compile enlighten.c and grant_table.c from arch/arm.
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> > [....]
> > +#define HYPERCALL_SIMPLE(hypercall) \
> > +ENTRY(HYPERVISOR_##hypercall) \
> > + mov x16, #__HYPERVISOR_##hypercall; \
> > + hvc XEN_IMM; \
> > + ret; \
>
> Not sure if this is corruption due to whitespace/email etc but it'd be
> nice to align those \'s.

They are aligned with ts=4, misaligned with ts=8 (ts is vim terminology
for "how many spaces a tab equals to") :-/

Given that according to Linux coding style tabs are 8 characters, I'll
fix the indentation.