public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	manabian@gmail.com, linux-pcmcia@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux@dominikbrodowski.net,
	fabio.porcedda@gmail.com,
	Andrew Morton <akpm@linux-foundation.org>,
	laurent.navet@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/7] pcmcia: at91_cf: fix gpio_get_value in at91_cf_get_status
Date: Thu, 6 Jun 2013 18:15:44 +0200	[thread overview]
Message-ID: <20130606161544.GN23653@game.jcrosoft.org> (raw)
In-Reply-To: <cc6a02cb9d55ba52b48adca688fef362b8bea373.1370506678.git.nicolas.ferre@atmel.com>

On 10:24 Thu 06 Jun     , Nicolas Ferre wrote:
> From: Joachim Eastwood <manabian@gmail.com>
> 
> Commit 80af9e6d (pcmcia at91_cf: fix raw gpio number usage) forgot
> to change the parameter in gpio_get_value after adding gpio
> validation.

this is a fix so should for in stable tree too

since #3.4

Best Regards,
J.
> 
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
>  drivers/pcmcia/at91_cf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c
> index 01463c7..1b2c631 100644
> --- a/drivers/pcmcia/at91_cf.c
> +++ b/drivers/pcmcia/at91_cf.c
> @@ -100,9 +100,9 @@ static int at91_cf_get_status(struct pcmcia_socket *s, u_int *sp)
>  		int vcc	= gpio_is_valid(cf->board->vcc_pin);
>  
>  		*sp = SS_DETECT | SS_3VCARD;
> -		if (!rdy || gpio_get_value(rdy))
> +		if (!rdy || gpio_get_value(cf->board->irq_pin))
>  			*sp |= SS_READY;
> -		if (!vcc || gpio_get_value(vcc))
> +		if (!vcc || gpio_get_value(cf->board->vcc_pin))
>  			*sp |= SS_POWERON;
>  	} else
>  		*sp = 0;
> -- 
> 1.8.2.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2013-06-06 16:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06  8:24 [PATCH v3 0/7] pcmcia: at91_cf: clean up and add DT support Nicolas Ferre
2013-06-06  8:24 ` [PATCH v3 1/7] pcmcia: at91_cf: fix gpio_get_value in at91_cf_get_status Nicolas Ferre
2013-06-06 16:15   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-06-06  8:24 ` [PATCH v3 2/7] pcmcia: at91_cf: convert to dev_ print functions Nicolas Ferre
2013-06-06  8:24 ` [PATCH v3 3/7] pcmcia: at91_cf: use devm_ functions for allocations Nicolas Ferre
2013-06-06  8:24 ` [PATCH v3 4/7] pcmcia: at91_cf: clean up header includes Nicolas Ferre
2013-06-06  8:24 ` [PATCH v3 5/7] pcmcia: at91_cf: add support for DT Nicolas Ferre
2013-06-06  8:24 ` [PATCH v3 6/7] pcmcia: at91_cf: use module_platform_driver_probe() Nicolas Ferre
2013-06-06  8:24 ` [PATCH v3 7/7] pcmcia/trivial: at91_cf: fix checkpatch error Nicolas Ferre
2013-06-06 16:14 ` [PATCH v3 0/7] pcmcia: at91_cf: clean up and add DT support Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130606161544.GN23653@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=akpm@linux-foundation.org \
    --cc=fabio.porcedda@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.navet@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=linux@dominikbrodowski.net \
    --cc=manabian@gmail.com \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox