Re: [PATCH v3 0/4] Input: cyttsp4 - driver for Cypress TMA4XX touchscreen devices

Javier Martinez Canillas
2013-06-07T07:49:38Z

Hi Ferruh,

On Tue, Jun 4, 2013 at 11:34 AM, Ferruh Yigit <fery@cypress.com> wrote:
> This driver is for Cypress TrueTouch(tm) Standard Product controllers,
> Generation4 devices.
>
> This is third version of submission code, modifications:
> - code re-structured to match with existing Generation3 driver code.
> - common I2C code for Gen3 and Gen4 devices split and shared.
>

Thanks a lot for reusing as much as possible from the existing Gen3
driver. This is exactly what I meant in my feedback on your second
version of the driver.

> Driver consist of three modules:
> - Core module: Main module, gets data from TTSP controller,
> sent MT events to Linux
> - I2C module: Underlying communication with I2C bus
> - SPI module: Underlying communication with SPI bus
>
> Ferruh Yigit (4):
> Input: cyttsp - I2C driver split into two modules
> Input: cyttsp4 - Core driver for Cypress TMA4XX touchscreen devices
> Input: cyttsp4 - I2C driver for Cypress TMA4XX touchscreen devices
> Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices
>

For the whole series:

Acked-by: Javier Martinez Canillas <javier@dowhile0.org>

> drivers/input/touchscreen/Kconfig | 30 +
> drivers/input/touchscreen/Makefile | 5 +-
> drivers/input/touchscreen/cyttsp4_core.c | 2173 +++++++++++++++++++++++++
> drivers/input/touchscreen/cyttsp4_core.h | 472 ++++++
> drivers/input/touchscreen/cyttsp4_i2c.c | 90 +
> drivers/input/touchscreen/cyttsp4_spi.c | 205 +++
> drivers/input/touchscreen/cyttsp_core.c | 6 +-
> drivers/input/touchscreen/cyttsp_core.h | 11 +-
> drivers/input/touchscreen/cyttsp_i2c.c | 50 +-
> drivers/input/touchscreen/cyttsp_i2c_common.c | 79 +
> drivers/input/touchscreen/cyttsp_spi.c | 38 +-
> include/linux/platform_data/cyttsp4.h | 76 +
> 12 files changed, 3161 insertions(+), 74 deletions(-)
> create mode 100644 drivers/input/touchscreen/cyttsp4_core.c
> create mode 100644 drivers/input/touchscreen/cyttsp4_core.h
> create mode 100644 drivers/input/touchscreen/cyttsp4_i2c.c
> create mode 100644 drivers/input/touchscreen/cyttsp4_spi.c
> create mode 100644 drivers/input/touchscreen/cyttsp_i2c_common.c
> create mode 100644 include/linux/platform_data/cyttsp4.h
>
> --
> 1.7.9.5
>

Best regards,
Javier