From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754931Ab3FFVMu (ORCPT ); Thu, 6 Jun 2013 17:12:50 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:30557 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754720Ab3FFVMq (ORCPT ); Thu, 6 Jun 2013 17:12:46 -0400 Date: Fri, 7 Jun 2013 00:11:37 +0300 From: Dan Carpenter To: Joe Perches Cc: Johannes Schilling , devel@driverdev.osuosl.org, Kurt Kanzenbach , linux-kernel@i4.cs.fau.de, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Al Cho , Amarjargal Gundjalam , Laura Lawniczak Subject: Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err Message-ID: <20130606211137.GC28112@mwanda> References: <20130605094517.GS28112@mwanda> <1370535050-7167-1-git-send-email-of82ecuq@cip.cs.fau.de> <1370535050-7167-4-git-send-email-of82ecuq@cip.cs.fau.de> <1370541200.2209.6.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1370541200.2209.6.camel@joe-AO722> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 06, 2013 at 10:53:20AM -0700, Joe Perches wrote: > On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: > > From: Laura Lawniczak > [] > > diff --git a/drivers/staging/keucr/init.c b/drivers/staging/keucr/init.c > [] > > @@ -19,13 +19,13 @@ int ENE_InitMedia(struct us_data *us) > [] > > - printk(KERN_INFO "MiscReg03 = %x\n", MiscReg03); > > + dev_info(&us->pusb_dev->dev, "MiscReg03 = %x\n", MiscReg03); > > I suggest adding a few convenience macros to make > this a bit shorter and more likely to fit on a single > line without exceeding 80 cols. > > Adding something like: > > #define us_(us, fmt, ...) \ > dev_(&us->pusb_dev->dev, fmt, ##__VA_ARGS__) > > so these uses become > > us_info(us, "MiscReg03\n", MiscReg03); > > which is shorter and more readable. > Wait what? That's not a readable example. Why are we passing the MiscReg03 variable when there is no %d in the string? You're a big fan of custom printk macros but it's better if people can stick the to the normal ones if possible. In this case, just using a local variable is enough: dev_dbg(us_dev, "scsi cmd %X --- SCSIOP_ALLOW_MEDIUM_REMOVAL\n", cmd); 79 characters. Anyway this could fixed in a later patch. regards, dan carpenter