From: Dan Carpenter <dan.carpenter@oracle.com>
To: Johannes Schilling <of82ecuq@cip.cs.fau.de>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Kurt Kanzenbach <shifty91@gmail.com>,
linux-kernel@i4.cs.fau.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Al Cho <acho@novell.com>,
Amarjargal Gundjalam <amarjargal16@gmail.com>,
Laura Lawniczak <laura.lawniczak@googlemail.com>
Subject: Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err
Date: Fri, 7 Jun 2013 00:14:22 +0300 [thread overview]
Message-ID: <20130606211422.GD28112@mwanda> (raw)
In-Reply-To: <1370535050-7167-4-git-send-email-of82ecuq@cip.cs.fau.de>
On Thu, Jun 06, 2013 at 06:10:47PM +0200, Johannes Schilling wrote:
> @@ -321,7 +320,7 @@ int ENE_Write_Data(struct us_data *us, void *buf, unsigned int length)
> /*
> * usb_stor_print_cmd():
> */
> -void usb_stor_print_cmd(struct scsi_cmnd *srb)
> +void usb_stor_print_cmd(struct us_data *us,struct scsi_cmnd *srb)
^^
Missing space. Run checkpatch.pl over your patch to find these.
This can be fixed in a later patch I think.
> {
> PBYTE Cdb = srb->cmnd;
> DWORD cmd = Cdb[0];
regards,
dan carpenter
next prev parent reply other threads:[~2013-06-06 21:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 8:50 [PATCH 0/6] keucr: checkpatch fixes Johannes Schilling
2013-06-05 8:50 ` [PATCH 1/6] keucr: remove some unneccesary typedefs Johannes Schilling
2013-06-05 9:25 ` Dan Carpenter
2013-06-05 8:50 ` [PATCH 2/6] keucr: fix some camelCase warnings Johannes Schilling
2013-06-05 9:23 ` Dan Carpenter
2013-06-05 9:48 ` Dan Carpenter
2013-06-05 8:50 ` [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err Johannes Schilling
2013-06-05 9:32 ` Dan Carpenter
2013-06-05 8:50 ` [PATCH 4/6] keucr: make error messages less aggressive Johannes Schilling
2013-06-05 9:36 ` Dan Carpenter
2013-06-05 8:50 ` [PATCH 5/6] keucr: fix some alignment- and whitespace-problems Johannes Schilling
2013-06-05 8:50 ` [PATCH 6/6] keucr: use more specific max_t(int, Johannes Schilling
2013-06-05 9:45 ` Dan Carpenter
2013-06-06 16:10 ` [PATCH 0/6] keucr: checkpatch fixes Johannes Schilling
2013-06-06 16:10 ` [PATCH 1/6] keucr: remove some unneccesary typedefs Johannes Schilling
2013-06-06 16:10 ` [PATCH 2/6] keucr: use more specific max_t(int, Johannes Schilling
2013-06-06 16:10 ` [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err Johannes Schilling
2013-06-06 17:53 ` Joe Perches
2013-06-06 21:11 ` Dan Carpenter
2013-06-06 21:23 ` Joe Perches
2013-06-06 22:07 ` Dan Carpenter
2013-06-06 21:14 ` Dan Carpenter [this message]
2013-06-06 16:10 ` [PATCH 4/6] keucr: more readable and friendly error messages Johannes Schilling
2013-06-06 21:48 ` Dan Carpenter
2013-06-06 16:10 ` [PATCH 5/6] keucr: moved function to other file Johannes Schilling
2013-06-06 21:23 ` Dan Carpenter
2013-06-06 16:10 ` [PATCH 6/6] keucr: fix some alignment- and whitespace-problems Johannes Schilling
2013-06-06 18:03 ` Joe Perches
2013-06-06 21:44 ` Dan Carpenter
2013-06-06 18:47 ` [PATCH 0/6] keucr: checkpatch fixes Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606211422.GD28112@mwanda \
--to=dan.carpenter@oracle.com \
--cc=acho@novell.com \
--cc=amarjargal16@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laura.lawniczak@googlemail.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=of82ecuq@cip.cs.fau.de \
--cc=shifty91@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox