From: Dan Carpenter <dan.carpenter@oracle.com>
To: Laura Lawniczak <laura.lawniczak@googlemail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
Kurt Kanzenbach <shifty91@gmail.com>,
linux-kernel@i4.cs.fau.de,
Johannes Schilling <of82ecuq@cip.cs.fau.de>,
linux-kernel@vger.kernel.org, Al Cho <acho@novell.com>,
Amarjargal Gundjalam <amarjargal16@gmail.com>
Subject: Re: [PATCH 1/1] keucr: restored lost line
Date: Fri, 7 Jun 2013 00:56:42 +0300 [thread overview]
Message-ID: <20130606215642.GH28112@mwanda> (raw)
In-Reply-To: <1370551851-13456-2-git-send-email-laura.lawniczak@googlemail.com>
On Thu, Jun 06, 2013 at 10:50:51PM +0200, Laura Lawniczak wrote:
> This line was unfortunately removed during patch process. This caused an
> "unused variable" warning and may cause other unintended effects.
> So here it is again.
>
Oh wow... I noticed this in the first patch and I couldn't figure
out why the blen = 0 was there... It never occurred to me that it
was to silence the warning. :P That's hilarious.
The blen variable is only used in commented out code. Don't do
this. Please delete everything to do with blen. It's there in the
history if anyone wants to see it. Delete "bn" as well.
regards,
dan carpenter
next prev parent reply other threads:[~2013-06-06 21:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130606201631.GB14773@kroah.com>
2013-06-06 20:50 ` [PATCH 0/1] keucr: remove unused variable warning Laura Lawniczak
2013-06-06 20:50 ` [PATCH 1/1] keucr: restored lost line Laura Lawniczak
2013-06-06 21:56 ` Dan Carpenter [this message]
2013-06-06 21:57 ` Greg KH
2013-06-07 13:08 ` [PATCH] keucr: removed unnecessary variables and comments Laura Lawniczak
2013-06-09 5:28 ` Greg KH
2013-06-09 21:11 ` Johannes Schilling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606215642.GH28112@mwanda \
--to=dan.carpenter@oracle.com \
--cc=acho@novell.com \
--cc=amarjargal16@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laura.lawniczak@googlemail.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=of82ecuq@cip.cs.fau.de \
--cc=shifty91@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox