From: Johan Hovold <jhovold@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Tobias Winter" <tobias@linuxdingsda.de>,
"Bjørn Mork" <bjorn@mork.no>, "Rob Landley" <rob@landley.net>,
"Johan Hovold" <jhovold@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic
Date: Fri, 7 Jun 2013 12:00:47 +0200 [thread overview]
Message-ID: <20130607100047.GM2566@localhost> (raw)
In-Reply-To: <20130606173121.GA1866@kroah.com>
On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> @@ -1040,11 +1044,10 @@ static int usb_serial_probe(struct usb_i
> */
> serial->disconnected = 1;
>
> - if (get_free_serial(serial, num_ports, &minor) == NULL) {
> + if (get_free_serial(serial, num_ports)) {
> dev_err(ddev, "No more free serial devices\n");
> goto probe_error;
> }
> - serial->minor = minor;
This gives a warning as minor is no longer initialised, but is still
used to initialise the console a bit further down.
usb_serial_console_init(minor);
Should probably just drop minor, and use serial->port[0]->minor instead.
Thanks,
Johan
next prev parent reply other threads:[~2013-06-07 10:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 17:31 [PATCH v2 0/3] Increase the number of USB to serial devices we can support at once Greg KH
2013-06-06 17:31 ` [PATCH v2 2/3] USB: serial: make minor allocation dynamic Greg KH
2013-06-07 9:40 ` Johan Hovold
2013-06-07 9:50 ` Johan Hovold
2013-06-07 17:58 ` Greg KH
2013-06-07 10:00 ` Johan Hovold [this message]
2013-06-07 17:24 ` Greg KH
2013-06-07 18:04 ` [PATCH v3 " Greg KH
2013-06-08 10:03 ` Johan Hovold
2013-06-17 20:16 ` Greg KH
2013-06-18 10:23 ` Johan Hovold
2013-06-06 17:31 ` [PATCH v2 3/3] USB: serial: increase the number of devices we support Greg KH
2013-06-06 17:32 ` [PATCH v2 1/3] USB: serial: ports: add minor and port number Greg KH
2013-06-07 6:00 ` [PATCH v2 0/3] Increase the number of USB to serial devices we can support at once Tobias Winter
2013-06-07 9:55 ` Tobias Winter
2013-06-07 17:25 ` Greg KH
2013-06-08 9:14 ` Tobias Winter
2013-06-08 14:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607100047.GM2566@localhost \
--to=jhovold@gmail.com \
--cc=bjorn@mork.no \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rob@landley.net \
--cc=tobias@linuxdingsda.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox