From: Olof Johansson <olof@lixom.net>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: "'Doug Anderson'" <dianders@chromium.org>,
"'Thomas Abraham'" <thomas.abraham@linaro.org>,
"'Simon Glass'" <sjg@chromium.org>,
linux-samsung-soc@vger.kernel.org,
"'Tomasz Figa'" <tomasz.figa@gmail.com>,
"'Russell King'" <linux@arm.linux.org.uk>,
"'Ben Dooks'" <ben-linux@fluff.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: exynos: add debug_ll_io_init() call in exynos_init_io()
Date: Fri, 7 Jun 2013 18:12:22 -0700 [thread overview]
Message-ID: <20130608011222.GC27436@quad.lixom.net> (raw)
In-Reply-To: <09ca01ce6244$e2f0e7a0$a8d2b6e0$%kim@samsung.com>
On Thu, Jun 06, 2013 at 08:32:04AM +0900, Kukjin Kim wrote:
> Olof Johansson wrote:
> >
> > On Wed, Jun 5, 2013 at 1:56 PM, Doug Anderson <dianders@chromium.org>
> > wrote:
> > > If the early MMU mapping of the UART happens to get booted out of the
> > > TLB between the start of paging_init() and when we finally re-add the
> > > UART at the very end of s3c_init_cpu(), we'll get a hang at bootup if
> > > we've got early_printk enabled. Avoid this hang by calling
> > > debug_ll_io_init() early.
> > >
> > > Without this patch, you can reliably reproduce a hang when early
> > > printk is enabled by adding flush_tlb_all() at the start of
> > > exynos_init_io(). After this patch the hang goes away.
> > >
> > > Signed-off-by: Doug Anderson <dianders@chromium.org>
> >
> > Acked-by: Olof Johansson <olof@lixom.net>
> >
> >
> > Kukjin, this seems appropriate for 3.10. Do you have other fixes
> > queued or should I apply this directly?
> >
> If I remember correctly, nothing in my tree for 3.10.
>
> So please go ahead with my ack if you want,
>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
>
Applied for 3.10 (together with the uncompress.h fix from Tushar)
-Olof
prev parent reply other threads:[~2013-06-08 1:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 1:58 [PATCH] ARM: samsung: avoid racy early printk at bootup Doug Anderson
2013-06-05 3:15 ` Olof Johansson
2013-06-05 20:56 ` Doug Anderson
2013-06-05 20:56 ` [PATCH v2] ARM: exynos: add debug_ll_io_init() call in exynos_init_io() Doug Anderson
2013-06-05 21:12 ` Olof Johansson
2013-06-05 23:32 ` Kukjin Kim
2013-06-08 1:12 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130608011222.GC27436@quad.lixom.net \
--to=olof@lixom.net \
--cc=ben-linux@fluff.org \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sjg@chromium.org \
--cc=thomas.abraham@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox