From: Greg KH <gregkh@linuxfoundation.org>
To: Tobias Winter <tobias@linuxdingsda.de>
Cc: "Bjørn Mork" <bjorn@mork.no>, "Rob Landley" <rob@landley.net>,
"Johan Hovold" <jhovold@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Increase the number of USB to serial devices we can support at once
Date: Sat, 8 Jun 2013 07:26:01 -0700 [thread overview]
Message-ID: <20130608142601.GA32217@kroah.com> (raw)
In-Reply-To: <51B2F607.3020204@linuxdingsda.de>
On Sat, Jun 08, 2013 at 11:14:47AM +0200, Tobias Winter wrote:
> On 06/07/2013 07:25 PM, Greg KH wrote:
> > On Fri, Jun 07, 2013 at 11:55:59AM +0200, Tobias Winter wrote:
> >> On 06/07/2013 08:00 AM, Tobias Winter wrote:
> >>> CC drivers/usb/serial/console.o
> >>> drivers/usb/serial/console.c: In function ‘usb_console_setup’:
> >>> drivers/usb/serial/console.c:111:2: error: implicit declaration of
> >>> function ‘usb_serial_get_by_index’ [-Werror=implicit-function-declaration]
> >>> drivers/usb/serial/console.c:111:9: warning: assignment makes pointer
> >>> from integer without a cast [enabled by default]
> >>> drivers/usb/serial/console.c:122:40: error: ‘struct usb_serial’ has no
> >>> member named ‘minor’
> >>> cc1: some warnings being treated as errors
> >>> make[4]: *** [drivers/usb/serial/console.o] Error 1
> >>> make[3]: *** [drivers/usb/serial] Error 2
> >>> make[2]: *** [drivers/usb] Error 2
> >>> make[1]: *** [drivers] Error 2
> >>> make[1]: Leaving directory `/root/usb.git'
> >>> make: *** [debian/stamp/build/kernel] Error 2
> >>
> >> Despite that broken driver, I just gave it a try and the patchset works
> >> as expected.
> >
> > Thanks for testing, I forgot to update the console code, as no one sane
> > every runs it :)
> >
> > I'll go fix that up now...
> I just retested it and it works as expected.
Wonderful, thanks for testing.
greg k-h
prev parent reply other threads:[~2013-06-08 14:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 17:31 [PATCH v2 0/3] Increase the number of USB to serial devices we can support at once Greg KH
2013-06-06 17:31 ` [PATCH v2 2/3] USB: serial: make minor allocation dynamic Greg KH
2013-06-07 9:40 ` Johan Hovold
2013-06-07 9:50 ` Johan Hovold
2013-06-07 17:58 ` Greg KH
2013-06-07 10:00 ` Johan Hovold
2013-06-07 17:24 ` Greg KH
2013-06-07 18:04 ` [PATCH v3 " Greg KH
2013-06-08 10:03 ` Johan Hovold
2013-06-17 20:16 ` Greg KH
2013-06-18 10:23 ` Johan Hovold
2013-06-06 17:31 ` [PATCH v2 3/3] USB: serial: increase the number of devices we support Greg KH
2013-06-06 17:32 ` [PATCH v2 1/3] USB: serial: ports: add minor and port number Greg KH
2013-06-07 6:00 ` [PATCH v2 0/3] Increase the number of USB to serial devices we can support at once Tobias Winter
2013-06-07 9:55 ` Tobias Winter
2013-06-07 17:25 ` Greg KH
2013-06-08 9:14 ` Tobias Winter
2013-06-08 14:26 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130608142601.GA32217@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bjorn@mork.no \
--cc=jhovold@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rob@landley.net \
--cc=tobias@linuxdingsda.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox