From: Anton Vorontsov <anton@enomsg.org>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Andrew Chew <achew@nvidia.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 1/1] tps65090-charger: Fix AC detect
Date: Sun, 9 Jun 2013 10:03:47 -0700 [thread overview]
Message-ID: <20130609170347.GA23128@teo> (raw)
In-Reply-To: <51B2054B.7030609@nvidia.com>
On Fri, Jun 07, 2013 at 12:07:39PM -0400, Rhyland Klein wrote:
> On 6/6/2013 5:12 PM, Andrew Chew wrote:
> > The VACG interrupt was not being enabled. Thus, interrupts were never
> > generated when AC status changes. In addition, interrupts were never
> > cleared after taking and processing the interrupt.
> >
> > Added the register offset for the INTR_MASK register, since this is needed
> > to unmask the VACG interrupt.
> >
> > Enabled the VACG interrupt in tps65090_config_charger().
> >
> > Cleared interrupts after processing, in tps65090_charger_isr().
> >
> > Also removed unused variable "enable" in tps65090_enable_charging(),
> > and fixed a typo in one of the dev_err() prints.
> >
> > Signed-off-by: Andrew Chew <achew@nvidia.com>
> > ---
>
> Great! Tested and it works great on my Dalmore.
>
> Tested-by: Rhyland Klein <rklein@nvidia.com>
> Acked-by: Rhyland Klein <rklein@nvidia.com>
Applied, thanks!
Anton
prev parent reply other threads:[~2013-06-09 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 21:12 [PATCH 1/1] tps65090-charger: Fix AC detect Andrew Chew
2013-06-07 16:07 ` Rhyland Klein
2013-06-09 17:03 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130609170347.GA23128@teo \
--to=anton@enomsg.org \
--cc=achew@nvidia.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox