From: Emil Goode <emilgoode@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
David Woodhouse <dwmw2@infradead.org>,
artem.bityutskiy@linux.intel.com, andrew@lunn.ch,
Bill Pemberton <wfp5p@virginia.edu>,
Jingoo Han <jg1.han@samsung.com>,
linux-mtd@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe
Date: Mon, 10 Jun 2013 00:45:44 +0200 [thread overview]
Message-ID: <20130609224544.GB3963@debian> (raw)
In-Reply-To: <CAHp75VeDtfq3APDQsy2SP=wLrRPUJdVaBbfu4NcrWrC70wCebg@mail.gmail.com>
Hello,
Sorry for not responding earlier, I was away from my computer.
Thanks for the review, I will send a second version that applies
on top of Andy's patch and fix that typo in the change log.
Best regards,
Emil
On Mon, Jun 10, 2013 at 12:15:22AM +0300, Andy Shevchenko wrote:
> On Sun, Jun 9, 2013 at 11:57 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote:
> >> On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >> > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote:
>
> >> >> What about another patch (that I guess should go first) that converts
> >> >> printk to dev_* or pr_*?
> >>
> >> > Huh, what? Those are two totally unrelated things. Emil's patch is
> >> > a bug fix.
> >>
> >> To be precise his patch is bugfix and cleanup at once.
> >> My proposal is to add a clean up patch.
> >
> > The printk idea isn't a bad one, it's just totally unrelated to what
> > the patch is doing.
>
> I don't agree with word 'totally'. It touches probe function and
> shuffles code there.
>
> > You can't just randomly tell people to do a
> > bunch of work for no reason. "Good bugfix, but before we apply it
> > you have to mow my lawn."
>
> In this particular case I didn't think it's a big deal to fix 3 printfs.
> Anyway, see patch in the next message.
>
>
> --
> With Best Regards,
> Andy Shevchenko
prev parent reply other threads:[~2013-06-09 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 9:08 [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe Emil Goode
2013-06-09 17:15 ` Andy Shevchenko
2013-06-09 19:17 ` Dan Carpenter
2013-06-09 19:27 ` Andy Shevchenko
2013-06-09 20:57 ` Dan Carpenter
2013-06-09 21:15 ` Andy Shevchenko
2013-06-09 22:45 ` Emil Goode [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130609224544.GB3963@debian \
--to=emilgoode@gmail.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=dwmw2@infradead.org \
--cc=jg1.han@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox