From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Mike Frysinger <vapier@gentoo.org>,
takata@linux-m32r.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
realmz paranoid <realmz6@gmail.com>,
linux390@de.ibm.com,
"uclinux-dist-devel@blackfin.uclinux.org"
<uclinux-dist-devel@blackfin.uclinux.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org,
linux-s390@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>,
Marc Gauthier <Marc.Gauthier@tensilica.com>
Subject: Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long'
Date: Mon, 10 Jun 2013 11:21:06 +0200 [thread overview]
Message-ID: <20130610092106.GA4697@osiris> (raw)
In-Reply-To: <51B4214E.6090007@asianux.com>
On Sun, Jun 09, 2013 at 02:31:42PM +0800, Chen Gang wrote:
>
> atomic_set_mask() and atomic_clear_mask() are the pairs, so the related
> parameters' type need match with each other.
>
> The type of 'addr->counter' is 'int', so use 'unsigned int' instead
> of 'unsigned long', and let atomic_set_mask() match atomic_clear_mask().
>
>
> For arch sub-system, currently, have 3 types of definition for them:
> 1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'.
>
> At least, better to fix 3rd (conflict using 'int' and 'long').
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/blackfin/include/asm/atomic.h | 4 ++--
> arch/m32r/include/asm/atomic.h | 8 ++++----
> arch/s390/include/asm/atomic.h | 4 ++--
> include/asm-generic/atomic.h | 2 +-
> 4 files changed, 9 insertions(+), 9 deletions(-)
For the s390 part:
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
next prev parent reply other threads:[~2013-06-10 9:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 7:50 [PATCH] arch: asm-geniric: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long' Chen Gang
2013-06-08 8:31 ` Geert Uytterhoeven
2013-06-08 8:37 ` Chen Gang
2013-06-08 17:49 ` Bjorn Helgaas
2013-06-09 1:52 ` Chen Gang
2013-06-10 17:00 ` Bjorn Helgaas
2013-06-13 1:47 ` Chen Gang
2013-06-09 6:31 ` [PATCH v2] arch: asm-generic: " Chen Gang
2013-06-10 9:21 ` Heiko Carstens [this message]
2013-06-13 1:19 ` Chen Gang
2013-06-26 2:03 ` Chen Gang
2013-07-05 1:11 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130610092106.GA4697@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=Marc.Gauthier@tensilica.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=gang.chen@asianux.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r-ja@ml.linux-m32r.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=realmz6@gmail.com \
--cc=schwidefsky@de.ibm.com \
--cc=takata@linux-m32r.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox