From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753009Ab3FJKFt (ORCPT ); Mon, 10 Jun 2013 06:05:49 -0400 Received: from mail-ee0-f41.google.com ([74.125.83.41]:63816 "EHLO mail-ee0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752919Ab3FJKFr (ORCPT ); Mon, 10 Jun 2013 06:05:47 -0400 Date: Mon, 10 Jun 2013 11:05:40 +0100 From: Lee Jones To: J Keerthy Cc: b-cousson@ti.com, devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, ldewangan@nvidia.com, grant.likely@secretlab.ca, swarren@wwwdotorg.org, swarren@nvidia.com, sameo@linux.intel.com, gg@slimlogic.co.uk Subject: Re: [PATCH v2 2/2] ARM: dts: OMAP5: add palmas node and omap specific palmas regulator properties Message-ID: <20130610100540.GI20297@gmail.com> References: <1370855059-5342-1-git-send-email-j-keerthy@ti.com> <1370855059-5342-3-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1370855059-5342-3-git-send-email-j-keerthy@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Jun 2013, J Keerthy wrote: > Add palmas node and omap specific palmas regulator properties. > > Signed-off-by: J Keerthy > --- > arch/arm/boot/dts/omap5-uevm.dts | 147 ++++++++++++++++++++++++++++++++++++++ > 1 files changed, 147 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts > index 927db1e..ffbcc3f 100644 > --- a/arch/arm/boot/dts/omap5-uevm.dts > +++ b/arch/arm/boot/dts/omap5-uevm.dts > @@ -8,6 +8,8 @@ > /dts-v1/; > > #include "omap5.dtsi" > +#include > +#include > > / { > model = "TI OMAP5 uEVM board"; > @@ -254,6 +256,151 @@ > pinctrl-0 = <&i2c1_pins>; > > clock-frequency = <400000>; > + > + palmas: palmas@48 { > + reg = <0x48>; > + /* SPI = 0, IRQ# = 7, active high level-sensitive */ I still think this is superfluous, especially now you're using the defines which basically say the same thing. > + interrupts = ; /* IRQ_SYS_1N */ > + interrupt-parent = <&gic>; > + }; > + > +}; > + > +#include "palmas.dtsi" > + > +&palmas { > + palmas_pmic { > + ti,ldo6-vibrator; > + > + regulators { > + smps123_reg: smps123 { > + regulator-min-microvolt = < 600000>; > + regulator-max-microvolt = <1500000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + smps45_reg: smps45 { > + regulator-min-microvolt = < 600000>; > + regulator-max-microvolt = <1310000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + smps6_reg: smps6 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + smps7_reg: smps7 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + smps8_reg: smps8 { > + regulator-min-microvolt = < 600000>; > + regulator-max-microvolt = <1310000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + smps9_reg: smps9 { > + regulator-min-microvolt = <2100000>; > + regulator-max-microvolt = <2100000>; > + regulator-always-on; > + regulator-boot-on; > + ti,smps-range = <0x80>; > + }; > + > + smps10_reg: smps10 { > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + ldo1_reg: ldo1 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + ldo2_reg: ldo2 { > + regulator-min-microvolt = <2900000>; > + regulator-max-microvolt = <2900000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + ldo3_reg: ldo3 { > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + ldo4_reg: ldo4 { > + regulator-min-microvolt = <2200000>; > + regulator-max-microvolt = <2200000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + ldo5_reg: ldo5 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + ldo6_reg: ldo6 { > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1500000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + ldo7_reg: ldo7 { > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1500000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + ldo8_reg: ldo8 { > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1500000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + ldo9_reg: ldo9 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + ldoln_reg: ldoln { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + ldousb_reg: ldousb { > + regulator-min-microvolt = <3250000>; > + regulator-max-microvolt = <3250000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + }; > + }; > }; > > &i2c5 { -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog