Re: [PATCH 4/6] pci: Add PCIe driver for Samsung Exynos

Jingoo Han
2013-03-27T01:29:56Z

On Wednesday, March 27, 2013 6:33 AM, Rob Herring wrote:
>
> On 03/22/2013 11:07 PM, Jingoo Han wrote:
> > Exynos5440 has a PCIe controller which can be used as Root Complex.
> > This driver supports a PCIe controller as Root Complex mode.
> >
> > Signed-off-by: Surendranath Gurivireddy Balla <suren.reddy@samsung.com>
> > Signed-off-by: Siva Reddy Kallam <siva.kallam@samsung.com>
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > .../devicetree/bindings/pci/exynos-pcie.txt | 56 +
> > drivers/pci/host/Kconfig | 5 +
> > drivers/pci/host/Makefile | 1 +
> > drivers/pci/host/pci-exynos.c | 1139 ++++++++++++++++++++
> > 4 files changed, 1201 insertions(+), 0 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/pci/exynos-pcie.txt
> > create mode 100644 drivers/pci/host/Makefile
> > create mode 100644 drivers/pci/host/pci-exynos.c
>
> [...]
>
> > +
> > +/* synopsis specific PCIE configuration registers*/
>
> If this is a standard IP block, then the driver naming should reflect
> that. I suspect there are several others with the same IP block.

Sorry, I don't think so.
Only core block is a standard IP block, other parts are Exynos-specific.
So, it is hard to share with other PCIe IPs using synopsis core.

Best regards,
Jingoo Han

>
> Rob