From: Grant Likely <grant.likely@linaro.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
Thomas Gleixner <tglx@linutronix.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org, guohanjun@huawei.com
Subject: Re: [PATCH 3/7] irq: fix checkpatch error
Date: Tue, 11 Jun 2013 14:52:45 +0100 [thread overview]
Message-ID: <20130611135246.0717A3E0A90@localhost> (raw)
In-Reply-To: <1370517631-8684-4-git-send-email-wangkefeng.wang@huawei.com>
On Thu, 6 Jun 2013 19:20:27 +0800, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> ERROR: space required before the open parenthesis '('
> WARNING: Prefer pr_warn(... to pr_warning(...
> Just fix above 2 issue.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Applied, thanks.
g.
> ---
> kernel/irq/irqdomain.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 5a83dde..fd47f33 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -419,7 +419,7 @@ static void irq_domain_disassociate_many(struct irq_domain *domain,
> irq_data->hwirq = 0;
>
> /* Clear reverse map */
> - switch(domain->revmap_type) {
> + switch (domain->revmap_type) {
> case IRQ_DOMAIN_MAP_LINEAR:
> if (hwirq < domain->revmap_data.linear.size)
> domain->revmap_data.linear.revmap[hwirq] = 0;
> @@ -570,7 +570,7 @@ unsigned int irq_create_mapping(struct irq_domain *domain,
> if (domain == NULL)
> domain = irq_default_domain;
> if (domain == NULL) {
> - pr_warning("irq_create_mapping called for"
> + pr_warn("irq_create_mapping called for"
> " NULL domain, hwirq=%lx\n", hwirq);
> WARN_ON(1);
> return 0;
> @@ -672,7 +672,7 @@ unsigned int irq_create_of_mapping(struct device_node *controller,
> if (intsize > 0)
> return intspec[0];
> #endif
> - pr_warning("no irq domain found for %s !\n",
> + pr_warn("no irq domain found for %s !\n",
> of_node_full_name(controller));
> return 0;
> }
> --
> 1.8.2.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
next prev parent reply other threads:[~2013-06-11 13:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 11:20 [PATCH 0/7] irq: fix checkpatch errors and warnings Kefeng Wang
2013-06-06 11:20 ` [PATCH 1/7] irq: fix checkpatch warnings Kefeng Wang
2013-06-06 11:20 ` [PATCH 2/7] irq: fix checkpatch error Kefeng Wang
2013-06-06 11:20 ` [PATCH 3/7] " Kefeng Wang
2013-06-11 13:52 ` Grant Likely [this message]
2013-06-06 11:20 ` [PATCH 4/7] irq: fix all checkpatch errors and warnings Kefeng Wang
2013-06-06 11:20 ` [PATCH 5/7] " Kefeng Wang
2013-06-06 11:20 ` [PATCH 6/7] irq: fix checkpatch warnings Kefeng Wang
2013-06-06 11:20 ` [PATCH 7/7] irq: fix all checkpatch errors and warnings Kefeng Wang
2013-06-07 20:42 ` [PATCH 0/7] irq: fix " Thomas Gleixner
2013-06-07 22:24 ` Joe Perches
2013-06-08 3:32 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130611135246.0717A3E0A90@localhost \
--to=grant.likely@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox