Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

[Vinod Koul <vinod.koul@intel.com>]

On Wed, Jun 12, 2013 at 10:43:29AM +0300, Andy Shevchenko wrote:
> On Wed, Jun 12, 2013 at 8:08 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote:
> >> The dw_dmac driver is going to be split into multiple files. To make this more
> >> convenient move it to an own directory.
> >>
> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >> Acked-by: Arnd Bergmann <arnd@arndb.de>
> >> ---
> >> +config DW_DMAC
> >> +     tristate "Synopsys DesignWare AHB DMA support"
> >> +     depends on GENERIC_HARDIRQS
> >> +     select DMA_ENGINE
> >> +     default y if CPU_AT32AP7000
> >> +     help
> >> +       Support the Synopsys DesignWare AHB DMA controller. This
> >> +       can be integrated in chips such as the Atmel AT32ap7000.
> >> +
> >> +config DW_DMAC_BIG_ENDIAN_IO
> >> +     bool "Use big endian I/O register access"
> >> +     default y if AVR32
> >> +     depends on DW_DMAC
> >> +     help
> >> +       Say yes here to use big endian I/O access when reading and writing
> >> +       to the DMA controller registers. This is needed on some platforms,
> >> +       like the Atmel AVR32 architecture.
> > I know this is derived but should it be selected if AVR32 is defined, this stuff
> > should be user configurable..
> 
> I'm not sure I get what you meant. User can choose that option via
> make menuconfig or editing plain .config file.
> Or you meant this should be run-time configurable?
Something like
config DW_DMAC_BIG_ENDIAN_IO
	tristate

config DW_DMAC
	select DW_DMAC_BIG_ENDIAN_IO

I belive DW_DMAC is for AVR support and the PCI ones is different right.
The point is that these things should be selected by the required symbols based
on what ARCH we are on and not be prompted for user to configure via menuconfig

--
~Vinod
--