From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755877Ab3FLH4q (ORCPT ); Wed, 12 Jun 2013 03:56:46 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:65404 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280Ab3FLH4o (ORCPT ); Wed, 12 Jun 2013 03:56:44 -0400 Date: Wed, 12 Jun 2013 02:56:34 -0500 From: Calvin Owens To: Johannes Berg Cc: "Luis R. Rodriguez" , "John W. Linville" , Felix Fietkau , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath9k-devel@venema.h4ckr.net, netdev@vger.kernel.org Subject: Re: [PATCH] mac80211: ath9k: Use RCU protection calling ieee80211_get_tx_rates Message-ID: <20130612075634.GA1649@gmail.com> References: <20130609225120.GA2789@gmail.com> <20130610042959.GA1902@gmail.com> <1370950926.8356.14.camel@jlt4.sipsolutions.net> <20130611171304.GA2189@gmail.com> <1370980523.8356.70.camel@jlt4.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1370980523.8356.70.camel@jlt4.sipsolutions.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 06/11 at 21:55 +0200, Johannes Berg wrote: > Now the subject should no longer say "mac80211:" :) > > However... given that ieee80211_get_tx_rates() actually *copies* the > rates into the parameter, I guess it should do the rcu_read_lock() > internally. I guess I wasn't paying attention previously. Felix? I thought about that, but it seemed too simple, so I assumed I was missing something. ;) I'll send a patch per above. That makes the header file update unnecessary too. > johannes