public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.jf.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	spear-devel <spear-devel@list.st.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory
Date: Wed, 12 Jun 2013 13:42:02 +0530	[thread overview]
Message-ID: <20130612081202.GK4107@intel.com> (raw)
In-Reply-To: <CAHp75Vc=hO_FF0WMvhPm6MMRuCb+=MhOEOCSYb_TaCRf-xQ=sg@mail.gmail.com>

On Wed, Jun 12, 2013 at 11:38:37AM +0300, Andy Shevchenko wrote:
> On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote:
> >> On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> >>
> >> []
> >>
> >> > Something like
> >> > config DW_DMAC_BIG_ENDIAN_IO
> >> >         tristate
> >> >
> >> > config DW_DMAC
> >> >         select DW_DMAC_BIG_ENDIAN_IO
> >> >
> >> > I belive DW_DMAC is for AVR support and the PCI ones is different right.
> >> > The point is that these things should be selected by the required symbols based
> >> > on what ARCH we are on and not be prompted for user to configure via menuconfig
> >>
> >> DW_DMAC is a generic platform driver which supports AVR32, ARM and
> >> Intel (ACPI case) platforms.
> >>
> >> We may do that option invisible to user
> > Yup
> >>
> >> and then use
> >>
> >> config DW_DMAC
> >>          select DW_DMAC_BIG_ENDIAN_IO if ARCH=AVR32
> > Thats would be the right way
> 
> Do you prefer to have this as separate patch or integrated in the split?
> In my humble opinion I better to do separate patch.
Never mind, am applying your patches and below fix, let me if you guys are okay

diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig
index db2b41f..7be1cf8 100644
--- a/drivers/dma/dw/Kconfig
+++ b/drivers/dma/dw/Kconfig
@@ -10,6 +10,7 @@ config DW_DMAC_CORE
 config DW_DMAC
 	tristate "Synopsys DesignWare AHB DMA platform driver"
 	select DW_DMAC_CORE
+	select DW_DMAC_BIG_ENDIAN_IO if ARCH=AVR32
 	default y if CPU_AT32AP7000
 	help
 	  Support the Synopsys DesignWare AHB DMA controller. This
@@ -25,12 +26,4 @@ config DW_DMAC_PCI
 	  Intel Medfield has integrated this GPDMA controller.
 
 config DW_DMAC_BIG_ENDIAN_IO
-	bool "Use big endian I/O register access"
-	default y if AVR32
-	depends on DW_DMAC_CORE
-	help
-	  Say yes here to use big endian I/O access when reading and writing
-	  to the DMA controller registers. This is needed on some platforms,
-	  like the Atmel AVR32 architecture.
-
-	  If unsure, use the default setting.
+	bool
-

--
~Vinod

  reply	other threads:[~2013-06-12  8:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05 12:26 [PATCH v2 0/4] dw_dmac: move to own folder and split Andy Shevchenko
2013-06-05 12:26 ` [PATCH v2 1/4] dw_dmac: don't check resource with devm_ioremap_resource Andy Shevchenko
2013-06-05 12:26 ` [PATCH v2 2/4] dma: move dw_dmac driver to an own directory Andy Shevchenko
2013-06-12  5:08   ` Vinod Koul
2013-06-12  7:43     ` Andy Shevchenko
2013-06-12  7:39       ` Vinod Koul
2013-06-12  8:24         ` Viresh Kumar
2013-06-12  8:27         ` Andy Shevchenko
2013-06-12  7:52           ` Vinod Koul
2013-06-12  8:38             ` Andy Shevchenko
2013-06-12  8:12               ` Vinod Koul [this message]
2013-06-12  8:53                 ` Viresh Kumar
2013-06-12  8:19                   ` Vinod Koul
2013-06-12  9:06                     ` Viresh Kumar
2013-06-12  9:07                     ` Andy Shevchenko
2013-06-12  9:02                       ` Vinod Koul
2013-06-12  9:43                         ` Viresh Kumar
2013-06-12 11:36                         ` Arnd Bergmann
2013-06-12  9:00                 ` Andy Shevchenko
2013-06-12 13:52                   ` Hein Tibosch
2013-06-05 12:26 ` [PATCH v2 3/4] dma: dw: split driver to library part and platform code Andy Shevchenko
2013-06-05 12:26 ` [PATCH v2 4/4] dma: dw: add PCI part of the driver Andy Shevchenko
2013-06-11 12:39 ` [PATCH v2 0/4] dw_dmac: move to own folder and split Andy Shevchenko
2013-06-12  5:17   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130612081202.GK4107@intel.com \
    --to=vinod.koul@intel.com \
    --cc=andriy.shevchenko@linux.jf.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=balbi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spear-devel@list.st.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox