From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754629Ab3FLIvz (ORCPT ); Wed, 12 Jun 2013 04:51:55 -0400 Received: from mga09.intel.com ([134.134.136.24]:52775 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183Ab3FLIvx (ORCPT ); Wed, 12 Jun 2013 04:51:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,850,1363158000"; d="scan'208";a="352156329" Date: Wed, 12 Jun 2013 13:42:02 +0530 From: Vinod Koul To: Andy Shevchenko Cc: Andy Shevchenko , "linux-kernel@vger.kernel.org" , spear-devel , Viresh Kumar , Arnd Bergmann , Felipe Balbi Subject: Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory Message-ID: <20130612081202.GK4107@intel.com> References: <1370435206-13474-1-git-send-email-andriy.shevchenko@linux.intel.com> <1370435206-13474-3-git-send-email-andriy.shevchenko@linux.intel.com> <20130612050829.GB4107@intel.com> <20130612073806.GG4107@intel.com> <20130612075225.GI4107@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2013 at 11:38:37AM +0300, Andy Shevchenko wrote: > On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul wrote: > > On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote: > >> On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul wrote: > >> > >> [] > >> > >> > Something like > >> > config DW_DMAC_BIG_ENDIAN_IO > >> > tristate > >> > > >> > config DW_DMAC > >> > select DW_DMAC_BIG_ENDIAN_IO > >> > > >> > I belive DW_DMAC is for AVR support and the PCI ones is different right. > >> > The point is that these things should be selected by the required symbols based > >> > on what ARCH we are on and not be prompted for user to configure via menuconfig > >> > >> DW_DMAC is a generic platform driver which supports AVR32, ARM and > >> Intel (ACPI case) platforms. > >> > >> We may do that option invisible to user > > Yup > >> > >> and then use > >> > >> config DW_DMAC > >> select DW_DMAC_BIG_ENDIAN_IO if ARCH=AVR32 > > Thats would be the right way > > Do you prefer to have this as separate patch or integrated in the split? > In my humble opinion I better to do separate patch. Never mind, am applying your patches and below fix, let me if you guys are okay diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig index db2b41f..7be1cf8 100644 --- a/drivers/dma/dw/Kconfig +++ b/drivers/dma/dw/Kconfig @@ -10,6 +10,7 @@ config DW_DMAC_CORE config DW_DMAC tristate "Synopsys DesignWare AHB DMA platform driver" select DW_DMAC_CORE + select DW_DMAC_BIG_ENDIAN_IO if ARCH=AVR32 default y if CPU_AT32AP7000 help Support the Synopsys DesignWare AHB DMA controller. This @@ -25,12 +26,4 @@ config DW_DMAC_PCI Intel Medfield has integrated this GPDMA controller. config DW_DMAC_BIG_ENDIAN_IO - bool "Use big endian I/O register access" - default y if AVR32 - depends on DW_DMAC_CORE - help - Say yes here to use big endian I/O access when reading and writing - to the DMA controller registers. This is needed on some platforms, - like the Atmel AVR32 architecture. - - If unsure, use the default setting. + bool - -- ~Vinod