From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157Ab3FLJl4 (ORCPT ); Wed, 12 Jun 2013 05:41:56 -0400 Received: from mga03.intel.com ([143.182.124.21]:33009 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876Ab3FLJlz (ORCPT ); Wed, 12 Jun 2013 05:41:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,851,1363158000"; d="scan'208";a="315781162" Date: Wed, 12 Jun 2013 14:32:02 +0530 From: Vinod Koul To: Andy Shevchenko Cc: Viresh Kumar , Andy Shevchenko , "linux-kernel@vger.kernel.org" , spear-devel , Arnd Bergmann , Felipe Balbi Subject: Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory Message-ID: <20130612090202.GM4107@intel.com> References: <20130612050829.GB4107@intel.com> <20130612073806.GG4107@intel.com> <20130612075225.GI4107@intel.com> <20130612081202.GK4107@intel.com> <20130612081917.GL4107@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2013 at 12:07:24PM +0300, Andy Shevchenko wrote: > On Wed, Jun 12, 2013 at 11:19 AM, Vinod Koul wrote: > > On Wed, Jun 12, 2013 at 02:23:39PM +0530, Viresh Kumar wrote: > >> On 12 June 2013 13:42, Vinod Koul wrote: > >> > >> > Never mind, am applying your patches and below fix, let me if you guys are okay Also, please ensure you _run_ checkpatch. There were few trvial errors in this. I have fixed them up before applying > >> This information was useful to understand this config option and must > >> be kept in some way. > > Well now the config option is not selected by users, so they dont need to know. > > It was useful in knowing what to select earlier > > > > For documenting, we can add this in commit log or better in driver code where > > you use this > > The driver is better place if you decide to move it (drivers/dma/dw/regs.h). Okay here it is: diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig index db2b41f..7be1cf8 100644 --- a/drivers/dma/dw/Kconfig +++ b/drivers/dma/dw/Kconfig @@ -10,6 +10,7 @@ config DW_DMAC_CORE config DW_DMAC tristate "Synopsys DesignWare AHB DMA platform driver" select DW_DMAC_CORE + select DW_DMAC_BIG_ENDIAN_IO if ARCH=AVR32 default y if CPU_AT32AP7000 help Support the Synopsys DesignWare AHB DMA controller. This @@ -25,12 +26,4 @@ config DW_DMAC_PCI Intel Medfield has integrated this GPDMA controller. config DW_DMAC_BIG_ENDIAN_IO - bool "Use big endian I/O register access" - default y if AVR32 - depends on DW_DMAC_CORE - help - Say yes here to use big endian I/O access when reading and writing - to the DMA controller registers. This is needed on some platforms, - like the Atmel AVR32 architecture. - - If unsure, use the default setting. + bool diff --git a/drivers/dma/dw/regs.h b/drivers/dma/dw/regs.h index 07c5a6e..deb4274 100644 --- a/drivers/dma/dw/regs.h +++ b/drivers/dma/dw/regs.h @@ -101,6 +101,12 @@ struct dw_dma_regs { u32 DW_PARAMS; }; +/* + * Big endian I/O access when reading and writing to the DMA controller + * registers. This is needed on some platforms, like the Atmel AVR32 + * architecture. + */ + #ifdef CONFIG_DW_DMAC_BIG_ENDIAN_IO #define dma_readl_native ioread32be #define dma_writel_native iowrite32be -- ~Vinod