From: Thierry Reding <thierry.reding@gmail.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH v3 1/5] pwm: Add Renesas TPU PWM driver
Date: Wed, 12 Jun 2013 12:22:24 +0200 [thread overview]
Message-ID: <20130612102223.GC30841@mithrandir> (raw)
In-Reply-To: <1370958344-19470-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
On Tue, Jun 11, 2013 at 03:45:40PM +0200, Laurent Pinchart wrote:
[...]
> +static struct platform_driver tpu_driver = {
> + .probe = tpu_probe,
> + .remove = tpu_remove,
> + .driver = {
> + .name = "renesas_tpu_pwm",
You agreed to rename this to "renesas-tpu-pwm" after my review of v2.
Can you please fix that in the next version. It's the only remaining
issue: as I said, the other minor quibbles can be fixed up in a
subsequent patch.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-12 10:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 13:45 [PATCH v3 0/5] Renesas TPU PWM support Laurent Pinchart
2013-06-11 13:45 ` [PATCH v3 1/5] pwm: Add Renesas TPU PWM driver Laurent Pinchart
2013-06-12 10:22 ` Thierry Reding [this message]
2013-06-13 15:39 ` Laurent Pinchart
2013-06-11 13:45 ` [PATCH v3 2/5] ARM: mach-shmobile: armadillo800eva: Add backlight support Laurent Pinchart
2013-06-11 13:45 ` [PATCH v3 3/5] ARM: mach-shmobile: kota2: Use leds-pwm + pwm-rmob Laurent Pinchart
2013-06-12 5:33 ` Magnus Damm
2013-06-12 5:47 ` Simon Horman
2013-06-11 13:45 ` [PATCH v3 4/5] ARM: shmobile: sh73a0: Remove all GPIOs Laurent Pinchart
2013-06-11 13:45 ` [PATCH v3 5/5] leds: Remove leds-renesas-tpu driver Laurent Pinchart
2013-06-12 10:12 ` [PATCH v3 0/5] Renesas TPU PWM support Thierry Reding
2013-06-13 15:38 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612102223.GC30841@mithrandir \
--to=thierry.reding@gmail.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox