Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

Dmitry Torokhov
2013-06-10T18:03:18Z

Manish,

On Mon, Jun 10, 2013 at 10:23:16AM +0000, Vishwanathrao Badarkhe, Manish wrote:
> Hi Dmitry,
>
> On Mon, Jun 10, 2013 at 11:34:42, Dmitry Torokhov wrote:
> > Hi Manish,
> >
> > On Tue, May 21, 2013 at 02:24:17PM +0530, Vishwanathrao Badarkhe, Manish wrote:
> >
> > > + struct touchscreen_init_data *init_data = NULL;
> > > + int err;
> > > +
> > > + if (node)
> > > + node = of_find_node_by_name(node, "tsc");
> >
> > Why do you have to locate OF node manually instead of already having it attached to the device stucture?
>
> As TPS6507x is mfd device containing two nodes, regulator and touchscreen.
> It is necessary to use "of_find_node_by_name" to find child "tsc" node of
> TPS6507x MFD device.

I understand that TPS6507x is a MFD device, However, I still do not
understand why you do not attach OF data to the child platform device
representing touchscreen when you create it.

Thanks.

--
Dmitry