public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kent Overstreet <koverstreet@google.com>
To: Tejun Heo <theo@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	Oleg Nesterov <oleg@redhat.com>,
	Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH percpu/for-3.11] percpu-refcount: consistently use plain (non-sched) RCU
Date: Wed, 12 Jun 2013 13:55:00 -0700	[thread overview]
Message-ID: <20130612205500.GE6151@google.com> (raw)
In-Reply-To: <20130612204031.GA15092@htj.dyndns.org>

On Wed, Jun 12, 2013 at 01:40:32PM -0700, Tejun Heo wrote:
> From e96262150a513ce3d54ff221d4ace8aeec96e0bf Mon Sep 17 00:00:00 2001
> From: Tejun Heo <tj@kernel.org>
> Date: Wed, 12 Jun 2013 13:37:42 -0700
> 
> percpu_ref_get/put() are using preempt_disable/enable() while
> percpu_ref_kill() is using plain call_rcu() instead of
> call_rcu_sched().  This is buggy as grace periods of the two may not
> match.  Fix it by using plain RCU in percpu_ref_get/put().
> 
> (I suggested using sched RCU in the first place but there's no actual
>  benefit in doing so unless we're gonna introduce different variants
>  of get/put to be called while preemption is alredy disabled, which we
>  definitely shouldn't.)
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Rusty Russell <rusty@rustcorp.com.au>

Acked-by: Kent Overstreet <koverstreet@google.com>

  reply	other threads:[~2013-06-12 20:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12 20:40 [PATCH percpu/for-3.11] percpu-refcount: consistently use plain (non-sched) RCU Tejun Heo
2013-06-12 20:55 ` Kent Overstreet [this message]
2013-06-13  3:48 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130612205500.GE6151@google.com \
    --to=koverstreet@google.com \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=theo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox