From: Youquan Song <youquan.song@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Yinghai Lu <yinghai@kernel.org>,
Youquan Song <youquan.song@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <dave@sr71.net>, Toshi Kani <toshi.kani@hp.com>,
Youquan Song <youquan.song@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: cpu hotplug: possible_cpus broken (again?) next-20130607
Date: Wed, 12 Jun 2013 21:36:09 -0400 [thread overview]
Message-ID: <20130613013609.GA6348@linux-youquan.bj.intel.com> (raw)
In-Reply-To: <4005805.V3phb1agMs@vostro.rjw.lan>
> > Interesting, you are changing long standing meaning of maxcpus=
> >
> > We always use maxcpus=1 to have one cpu up, and later in user space
> > to online other cpus like
> > echo 1 > /sys/devices/system/cpuX/online.
> >
> > aka maxcpus= is a soft limit or initial online nr.
> >
> > we already have nr_cpus= for hard limit.
> >
> > So need to drop
> > commit 3e275a5ba367ab74b3a4e49114307baed989fcac
> > Author: Youquan Song <youquan.song@intel.com>
> > Date: Fri Jun 7 10:07:08 2013 +1000
> >
> > drivers/base/cpu.c: fix maxcpus boot option
>
> Agreed.
Yes. I also agree to drop it and the fix need more consideration.
I try use maxcpus to limit cpu number to debug a well known applition
because it fail to run when cpu number is larger to > 69.
When I use maxcpus at to limit the boot CPUs number, but udev will
enable all of the CPUs at 3.10 kernel automatically.
I also try maxcpus at 3.0 kernel, it does not show the maxcpus issue.
I have digged out recently, it is the commit at 3.2 kernel
8a25a2fd126c621f44f3aeaef80d51f00fc11639 "cpu: convert 'cpu' and
'machinecheck' sysdev_class to a regular subsystem" result in udev
automatically enable all of CPUs though maxcpus has been provided.
So the next, I need look at udev try to enable all of CPUs though
maxcpus provided. Possibly, it can also fix it in udev daemon.
Secondly, I think that the maxcpus= option description is too confused in
Documentation/kernel-parameters.txt. The maxcpus and nr_cpus option need
switch their name.
Currently:
maxcpus= [SMP] Maximum number of processors that an SMP kernel
should make use of. maxcpus=n : n >= 0 limits the
kernel to using 'n' processors. n=0 is a special case,
it is equivalent to "nosmp", which also disables
the IO APIC.
How about change to
maxcpus= [SMP] Maximum number of processors that an SMP kernel
bring up during booting. maxcpus=n : n >= 0 limits the
kernel to using 'n' processors. n=0 is a special case,
it is equivalent to "nosmp", which also disables
the IO APIC.
Thanks
-Youquan
next prev parent reply other threads:[~2013-06-12 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 21:51 cpu hotplug: possible_cpus broken (again?) next-20130607 Dave Hansen
2013-06-11 22:05 ` Rafael J. Wysocki
2013-06-11 22:17 ` Dave Hansen
2013-06-11 22:34 ` Rafael J. Wysocki
2013-06-11 22:32 ` Toshi Kani
2013-06-12 12:03 ` Youquan Song
2013-06-12 0:24 ` Dave Hansen
2013-06-12 12:32 ` Youquan Song
2013-06-12 4:07 ` Yinghai Lu
2013-06-12 11:02 ` Rafael J. Wysocki
2013-06-13 1:36 ` Youquan Song [this message]
2013-06-13 15:36 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613013609.GA6348@linux-youquan.bj.intel.com \
--to=youquan.song@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave@sr71.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=sfr@canb.auug.org.au \
--cc=toshi.kani@hp.com \
--cc=yinghai@kernel.org \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox