From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dave Chiluk <chiluk@canonical.com>
Cc: Petr Vandrovec <petr@vandrovec.name>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ncpfs: fix rmdir returns Device or resource busy
Date: Thu, 13 Jun 2013 03:01:22 +0100 [thread overview]
Message-ID: <20130613020122.GA20274@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130607161452.GI13110@ZenIV.linux.org.uk>
On Fri, Jun 07, 2013 at 05:14:52PM +0100, Al Viro wrote:
> On Fri, Jun 07, 2013 at 11:09:05AM -0500, Dave Chiluk wrote:
> > Can't you just use the patch from my original e-mail? Anyhow I attached
> > it an already signed-off patch.
> >
> > Al Viro Can you integrate it now?
>
> Applied... FWIW, patch directly in mail body is more convenient to deal with.
Actually, looking at that stuff... Why are we bothering with -EBUSY for
removal of busy directories on ncpfs, anyway? It's not just rmdir(), it's
overwriting rename() as well. IS_DEADDIR checks in fs/namei.c and fs/readdir.c
mean that the only method of ncpfs directories that might get called after
successful removal is ->setattr() and it would be trivial to add the check
in ncp_notify_change() that would make it fail for dead directories without
bothering the server at all...
Related question: what happens if you open / unlink / fchmod on ncpfs?
next prev parent reply other threads:[~2013-06-13 2:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 22:50 [PATCH] ncpfs: fix rmdir returns Device or resource busy Dave Chiluk
2013-05-31 21:40 ` Dave Chiluk
[not found] ` <CA+i2_De5HHw2H9SvZ=W+QAOcy0M7jFac88OK6aeYdJVCGL6b+A@mail.gmail.com>
2013-06-05 20:20 ` Dave Chiluk
2013-06-07 6:43 ` Petr Vandrovec
2013-06-07 16:09 ` Dave Chiluk
2013-06-07 16:14 ` Al Viro
2013-06-13 2:01 ` Al Viro [this message]
2013-06-13 6:42 ` Al Viro
2013-06-14 4:19 ` Dave Chiluk
2013-06-15 5:09 ` Al Viro
2013-06-15 5:26 ` Al Viro
2013-06-14 4:02 ` Dave Chiluk
2013-06-19 9:30 ` Luis Henriques
2013-06-26 1:05 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613020122.GA20274@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chiluk@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=petr@vandrovec.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox