Re: [PATCH percpu/for-3.11 1/2] percpu-refcount: add __must_check to percpu_ref_init() and don't use ACCESS_ONCE() in percpu_ref_kill_rcu()

Rusty Russell
2013-06-19T03:44:47Z

Tejun Heo <tj@kernel.org> writes:
> Two small changes.
>
> * Unlike most init functions, percpu_ref_init() allocates memory and
> may fail. Let's mark it with __must_check in case the caller
> forgets.

But it's quite OK to ignore OOM errors in builtin init functions.

It would be neatest to have it fail into slow mode, of course, but it's
probably not worth the pain.

Cheers,
Rusty.