From: Thierry Reding <thierry.reding@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] pwm: Fill in missing .owner fields
Date: Thu, 13 Jun 2013 20:23:31 +0200 [thread overview]
Message-ID: <20130613182330.GA32574@mithrandir> (raw)
In-Reply-To: <51B8F729.7030907@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
On Thu, Jun 13, 2013 at 12:33:13AM +0200, Lars-Peter Clausen wrote:
> On 06/12/2013 09:59 PM, Thierry Reding wrote:
> > On Wed, Jun 12, 2013 at 05:05:18PM +0530, Sachin Kamat wrote:
> >> Hi Thierry,
> >>
> >> On 12 June 2013 16:59, Thierry Reding <thierry.reding@gmail.com> wrote:
> >>> Some drivers don't set the .owner fields of the struct device_driver or
> >>> struct pwm_ops, which causes the module usage count to become wrong.
> >>
> >>
> >> Recently a patch [1] was added to solve this issue of missing .owner
> >> fileds in struct platform_driver.
> >
> > Yes I saw that, but thought it might be good to initialize them anyway.
> > Especially since a couple of the drivers are I2C and I believe there's
> > no similar patch for those. It shouldn't be difficult to come up with
> > the corresponding patch, though.
>
> I2C had the same actually for quite some time now.
I wasn't aware of that. Thanks for educating me. =)
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-06-13 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 11:29 [PATCH] pwm: Fill in missing .owner fields Thierry Reding
2013-06-12 11:35 ` Sachin Kamat
2013-06-12 19:59 ` Thierry Reding
2013-06-12 21:46 ` Greg Kroah-Hartman
2013-06-12 22:33 ` Lars-Peter Clausen
2013-06-13 18:23 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613182330.GA32574@mithrandir \
--to=thierry.reding@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox