public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt@sgi.com>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>, Robin Holt <holt@sgi.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [Trivial PATCH 14/33] sgi: xpc: Convert use of typedef ctl_table to struct ctl_table
Date: Thu, 13 Jun 2013 21:53:48 -0500	[thread overview]
Message-ID: <20130614025348.GV3658@sgi.com> (raw)
In-Reply-To: <4a2276e3c9bc2afc3b67651972a2a2b7f83b161c.1371177118.git.joe@perches.com>

On Thu, Jun 13, 2013 at 07:37:39PM -0700, Joe Perches wrote:
> This typedef is unnecessary and should just be removed.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Acked-by: Robin Holt <holt@sgi.com>

> ---
>  drivers/misc/sgi-xp/xpc_main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c
> index d971817..82dc574 100644
> --- a/drivers/misc/sgi-xp/xpc_main.c
> +++ b/drivers/misc/sgi-xp/xpc_main.c
> @@ -92,7 +92,7 @@ int xpc_disengage_timelimit = XPC_DISENGAGE_DEFAULT_TIMELIMIT;
>  static int xpc_disengage_min_timelimit;	/* = 0 */
>  static int xpc_disengage_max_timelimit = 120;
>  
> -static ctl_table xpc_sys_xpc_hb_dir[] = {
> +static struct ctl_table xpc_sys_xpc_hb_dir[] = {
>  	{
>  	 .procname = "hb_interval",
>  	 .data = &xpc_hb_interval,
> @@ -111,7 +111,7 @@ static ctl_table xpc_sys_xpc_hb_dir[] = {
>  	 .extra2 = &xpc_hb_check_max_interval},
>  	{}
>  };
> -static ctl_table xpc_sys_xpc_dir[] = {
> +static struct ctl_table xpc_sys_xpc_dir[] = {
>  	{
>  	 .procname = "hb",
>  	 .mode = 0555,
> @@ -126,7 +126,7 @@ static ctl_table xpc_sys_xpc_dir[] = {
>  	 .extra2 = &xpc_disengage_max_timelimit},
>  	{}
>  };
> -static ctl_table xpc_sys_dir[] = {
> +static struct ctl_table xpc_sys_dir[] = {
>  	{
>  	 .procname = "xpc",
>  	 .mode = 0555,
> -- 
> 1.8.1.2.459.gbcd45b4.dirty

  reply	other threads:[~2013-06-14  2:53 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  2:37 [Trivial PATCH 00/33] Remove uses of typedef ctl_table Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 01/33] arm: kernel: isa: Convert use of typedef ctl_table to struct ctl_table Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 02/33] frv: " Joe Perches
2013-06-14  8:57   ` David Howells
2013-06-14  2:37 ` [Trivial PATCH 03/33] ia64: crash: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 04/33] mips: lasat: sysctl: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 05/33] powerpc: idle: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 06/33] s390: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 07/33] tile: proc: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 08/33] x86: vdso: " Joe Perches
2013-06-19 18:43   ` [tip:x86/asm] x86/vdso: " tip-bot for Joe Perches
2013-06-19 18:47     ` H. Peter Anvin
2013-06-19 19:05       ` Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 09/33] cdrom: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 10/33] char: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 11/33] infiniband: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 12/33] macintosh: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 13/33] md: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 14/33] sgi: xpc: " Joe Perches
2013-06-14  2:53   ` Robin Holt [this message]
2013-06-14  2:37 ` [Trivial PATCH 15/33] parport: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 16/33] scsi_sysctl: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 17/33] coda: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 18/33] fscache: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 19/33] lockd: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 20/33] nfs: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 21/33] inotify: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 22/33] ntfs: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 23/33] ocfs2: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 24/33] quota: " Joe Perches
2013-06-21 12:59   ` Jan Kara
2013-06-14  2:37 ` [Trivial PATCH 25/33] xfs: " Joe Perches
2013-06-14  5:21   ` Dave Chinner
2013-06-14  5:33     ` Joe Perches
2013-06-14  6:18       ` Dave Chinner
2013-06-17 22:39         ` Ben Myers
2013-06-14  2:37 ` [Trivial PATCH 26/33] fs: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 27/33] key: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 28/33] ipv6: " Joe Perches
2013-06-20  6:18   ` David Miller
2013-06-14  2:37 ` [Trivial PATCH 29/33] ndisc: " Joe Perches
2013-06-20  6:18   ` David Miller
2013-06-14  2:37 ` [Trivial PATCH 30/33] ipc: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 31/33] sysctl: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 32/33] mm: " Joe Perches
2013-06-14  2:37 ` [Trivial PATCH 33/33] security: keys: " Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130614025348.GV3658@sgi.com \
    --to=holt@sgi.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox