From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dave Chiluk <chiluk@canonical.com>
Cc: Petr Vandrovec <petr@vandrovec.name>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] ncpfs: fix rmdir returns Device or resource busy
Date: Sat, 15 Jun 2013 06:26:31 +0100 [thread overview]
Message-ID: <20130615052631.GP4165@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130615050939.GO4165@ZenIV.linux.org.uk>
On Sat, Jun 15, 2013 at 06:09:39AM +0100, Al Viro wrote:
> BTW, in ncp_fill_cache() we have a provably pointless
> if (!ino)
> ino = find_inode_number(dentry, &qname);
> Check it out - any path that can lead there with ino == 0 will *not*
> have a positive dentry with such name, so this find_inode_number()
> call is just "waste some time and return 0". Cargo-cult, plain and
> simple...
Incidentally, the only other caller of find_inode_number() is equally
pointless, so I'm very inclined to kill the damn function off. Sure,
it's exported. And I'm fairly sure that its out-of-tree users are
just as fishy (as in Innsmouth)...
next prev parent reply other threads:[~2013-06-15 5:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 22:50 [PATCH] ncpfs: fix rmdir returns Device or resource busy Dave Chiluk
2013-05-31 21:40 ` Dave Chiluk
[not found] ` <CA+i2_De5HHw2H9SvZ=W+QAOcy0M7jFac88OK6aeYdJVCGL6b+A@mail.gmail.com>
2013-06-05 20:20 ` Dave Chiluk
2013-06-07 6:43 ` Petr Vandrovec
2013-06-07 16:09 ` Dave Chiluk
2013-06-07 16:14 ` Al Viro
2013-06-13 2:01 ` Al Viro
2013-06-13 6:42 ` Al Viro
2013-06-14 4:19 ` Dave Chiluk
2013-06-15 5:09 ` Al Viro
2013-06-15 5:26 ` Al Viro [this message]
2013-06-14 4:02 ` Dave Chiluk
2013-06-19 9:30 ` Luis Henriques
2013-06-26 1:05 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130615052631.GP4165@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chiluk@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petr@vandrovec.name \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox