public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] vfree: don't schedule free_work() if llist_add() returns F
@ 2013-06-15 18:40 Oleg Nesterov
  0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2013-06-15 18:40 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

vfree() only needs schedule_work(&p->wq) if p->list was empty,
otherwise vfree_deferred->wq is already pending or it is running
and didn't do llist_del_all() yet.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 mm/vmalloc.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index d365724..2b8f644 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1524,7 +1524,6 @@ static void __vunmap(const void *addr, int deallocate_pages)
  *	conventions for vfree() arch-depenedent would be a really bad idea)
  *
  *	NOTE: assumes that the object at *addr has a size >= sizeof(llist_node)
- *	
  */
 void vfree(const void *addr)
 {
@@ -1536,8 +1535,8 @@ void vfree(const void *addr)
 		return;
 	if (unlikely(in_interrupt())) {
 		struct vfree_deferred *p = &__get_cpu_var(vfree_deferred);
-		llist_add((struct llist_node *)addr, &p->list);
-		schedule_work(&p->wq);
+		if (llist_add((struct llist_node *)addr, &p->list))
+			schedule_work(&p->wq);
 	} else
 		__vunmap(addr, 1);
 }
-- 
1.5.5.1



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-06-15 18:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-15 18:40 [PATCH] vfree: don't schedule free_work() if llist_add() returns F Oleg Nesterov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox