public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH 3/7] MIPS: sibyte: Add missing sched.h header
       [not found] ` <1371477641-7989-4-git-send-email-markos.chandras@imgtec.com>
@ 2013-06-17 16:44   ` Ralf Baechle
  2013-06-17 18:33     ` Peter Zijlstra
  0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2013-06-17 16:44 UTC (permalink / raw)
  To: Markos Chandras
  Cc: linux-mips, sibyte-users, linux-kernel, Ingo Molnar,
	Peter Zijlstra

On Mon, Jun 17, 2013 at 03:00:37PM +0100, Markos Chandras wrote:

> It's needed for the TASK_INTERRUPTIBLE definition.
> 
> Fixes the following build problem:
> arch/mips/sibyte/common/sb_tbprof.c:235:4: error: 'TASK_INTERRUPTIBLE'
> undeclared (first use in this function)

Ideally sched.h should be included into the actual user of
TASK_INTERRUPTIBLE, the wake_up_interruptible macro in <linux/wait.h> but
that seems way too risky that close to a release.

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/7] MIPS: sibyte: Add missing sched.h header
  2013-06-17 16:44   ` [PATCH 3/7] MIPS: sibyte: Add missing sched.h header Ralf Baechle
@ 2013-06-17 18:33     ` Peter Zijlstra
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2013-06-17 18:33 UTC (permalink / raw)
  To: Ralf Baechle
  Cc: Markos Chandras, linux-mips, sibyte-users, linux-kernel,
	Ingo Molnar

On Mon, Jun 17, 2013 at 06:44:27PM +0200, Ralf Baechle wrote:
> On Mon, Jun 17, 2013 at 03:00:37PM +0100, Markos Chandras wrote:
> 
> > It's needed for the TASK_INTERRUPTIBLE definition.
> > 
> > Fixes the following build problem:
> > arch/mips/sibyte/common/sb_tbprof.c:235:4: error: 'TASK_INTERRUPTIBLE'
> > undeclared (first use in this function)
> 
> Ideally sched.h should be included into the actual user of
> TASK_INTERRUPTIBLE, the wake_up_interruptible macro in <linux/wait.h> but
> that seems way too risky that close to a release.

Oh man, there's include recursion hell waiting for you ;-)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-17 18:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1371477641-7989-1-git-send-email-markos.chandras@imgtec.com>
     [not found] ` <1371477641-7989-4-git-send-email-markos.chandras@imgtec.com>
2013-06-17 16:44   ` [PATCH 3/7] MIPS: sibyte: Add missing sched.h header Ralf Baechle
2013-06-17 18:33     ` Peter Zijlstra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox