From: Peter Zijlstra <peterz@infradead.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Markos Chandras <markos.chandras@imgtec.com>,
linux-mips@linux-mips.org, sibyte-users@bitmover.com,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 3/7] MIPS: sibyte: Add missing sched.h header
Date: Mon, 17 Jun 2013 20:33:34 +0200 [thread overview]
Message-ID: <20130617183334.GC3204@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20130617164427.GE10408@linux-mips.org>
On Mon, Jun 17, 2013 at 06:44:27PM +0200, Ralf Baechle wrote:
> On Mon, Jun 17, 2013 at 03:00:37PM +0100, Markos Chandras wrote:
>
> > It's needed for the TASK_INTERRUPTIBLE definition.
> >
> > Fixes the following build problem:
> > arch/mips/sibyte/common/sb_tbprof.c:235:4: error: 'TASK_INTERRUPTIBLE'
> > undeclared (first use in this function)
>
> Ideally sched.h should be included into the actual user of
> TASK_INTERRUPTIBLE, the wake_up_interruptible macro in <linux/wait.h> but
> that seems way too risky that close to a release.
Oh man, there's include recursion hell waiting for you ;-)
prev parent reply other threads:[~2013-06-17 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1371477641-7989-1-git-send-email-markos.chandras@imgtec.com>
[not found] ` <1371477641-7989-4-git-send-email-markos.chandras@imgtec.com>
2013-06-17 16:44 ` [PATCH 3/7] MIPS: sibyte: Add missing sched.h header Ralf Baechle
2013-06-17 18:33 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617183334.GC3204@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
--cc=mingo@redhat.com \
--cc=ralf@linux-mips.org \
--cc=sibyte-users@bitmover.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox