From: Andi Shyti <andi.shyti@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Andi Shyti <andi@etezian.org>,
arnd@arndb.de, linux-kernel@vger.kernel.org, pc@asdf.org,
oatilla@gmail.com
Subject: Re: [PATCH 01/19] bh1770glc: added input device interface
Date: Tue, 18 Jun 2013 01:27:39 +0200 [thread overview]
Message-ID: <20130617232739.GA4454@jack.whiskey> (raw)
In-Reply-To: <20130617225241.GB21613@kroah.com>
Hi Greg,
> > The driver generates an event in /dev/input/ under the name
> > 'bh1770'. It's a switch event where is reported '0' or '1'
> > whenever the sensor detects something crossing the threshold.
> >
> > Signed-off-by: Onur Atilla <oatilla@gmail.com>
> > Signed-off-by: Phil Carmody <pc@asdf.org>
> > Signed-off-by: Andi Shyti <andi@etezian.org>
> > ---
> > drivers/misc/bh1770glc.c | 58 +++++++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 57 insertions(+), 1 deletion(-)
>
> Doesn't this mean that this driver is now an "input" driver, so it
> shouldn't be using the odd sysfs api, and should move to the
> drivers/input/ directory tree?
The driver has also lots of interfaces in
sysfs that are used from userspace, like proximity value and
ambient light value.
What the input interface provides is just one of the features
from the driver. Shall I move it anyway?
Andi
next prev parent reply other threads:[~2013-06-17 23:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 18:20 [PATCH 00/19] misc: bh1770glc features and fixes Andi Shyti
2013-06-13 18:20 ` [PATCH 01/19] bh1770glc: added input device interface Andi Shyti
2013-06-17 22:52 ` Greg KH
2013-06-17 23:27 ` Andi Shyti [this message]
2013-06-17 23:36 ` Greg KH
2013-06-17 23:54 ` Andi Shyti
2013-06-17 23:55 ` Greg KH
2013-06-13 18:20 ` [PATCH 02/19] bh1770glc: different glass attenuation parameters Andi Shyti
2013-06-13 18:20 ` [PATCH 03/19] bh1770glc: lux0_glass_factor & lux0_comp_factor on sysfs Andi Shyti
2013-06-17 22:52 ` Greg KH
2013-06-17 23:28 ` Andi Shyti
2013-06-13 18:20 ` [PATCH 04/19] bh1770glc: Added raw lux output file for ALS to sysfs Andi Shyti
2013-06-13 18:20 ` [PATCH 05/19] bh1770glc: Removed obsolete offset settings from SFH7770 code Andi Shyti
2013-06-13 18:20 ` [PATCH 06/19] bh1770glc: removed proximity adjustement Andi Shyti
2013-06-13 18:20 ` [PATCH 07/19] bh1770glc: split read result function Andi Shyti
2013-06-13 18:20 ` [PATCH 08/19] bh1770glc: logic change in the proximity read Andi Shyti
2013-06-13 18:20 ` [PATCH 09/19] bh1770glc: use min_t instead of min Andi Shyti
2013-06-13 18:20 ` [PATCH 10/19] bh1770glc: use kstrtoul instead of strict_strtoul Andi Shyti
2013-06-13 18:20 ` [PATCH 11/19] bh1770glc: removed lux_read_raw_result() function Andi Shyti
2013-06-13 18:20 ` [PATCH 12/19] bh1770glc: Introduced dynamic threshold Andi Shyti
2013-06-13 18:20 ` [PATCH 13/19] bh1770glc: Code cleaning and aligning in source code Andi Shyti
2013-06-13 18:20 ` [PATCH 14/19] bh1770glc: Modified the neutral glass attenuation value Andi Shyti
2013-06-13 18:20 ` [PATCH 15/19] bh1770glc: Modified scaler variable Andi Shyti
2013-06-13 18:20 ` [PATCH 16/19] bh1770glc: Added sanity check for scf Andi Shyti
2013-06-13 18:20 ` [PATCH 17/19] bh1770glc: Implemented switch for interrupt operation Andi Shyti
2013-06-13 18:20 ` [PATCH 18/19] bh1770glc: Corrected proximity sensor rates Andi Shyti
2013-06-13 18:20 ` [PATCH 19/19] bh1770glc: Proximity sensor LED current update Andi Shyti
2013-06-17 22:54 ` [PATCH 00/19] misc: bh1770glc features and fixes Greg KH
2013-06-17 23:38 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617232739.GA4454@jack.whiskey \
--to=andi.shyti@gmail.com \
--cc=andi@etezian.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oatilla@gmail.com \
--cc=pc@asdf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox