Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

Adam Lee
2013-06-08T09:04:45Z

On Fri, Jun 07, 2013 at 05:16:15PM -0300, Henrique de Moraes Holschuh wrote:
> Can you get me the ACPI interface documentation? It should be simple
> to get it, but I haven't emailed the Lenovo BIOS engineers for some
> time.
>
> Basically, create a new LED method in thinkpad-acpi, lock it down to
> vendor lenovo, detect the new interfaces, and only check the
> two-argument LED one if the newer ones aren't found.
>
> Not supporting the old /proc interface on new thinkpads is fine.

Thanks, I will request the documentation from Lenovo again.

Please apply "[PATCH 1/3 v3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs" and
"[PATCH 2/3] thinkpad_acpi: add the ability setting TPACPI_LED_NONE by quirk", but
hold "[PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs",
I will drop [PATCH 3/3] to discussion again when I got the documentation.

--
Regards,
Adam Lee
Hardware Enablement