[PATCH] drm/tegra: Include linux/types.h

[PATCH] drm/tegra: Include linux/types.h

[Paul Bolle]

"make headers_check" complains about include/uapi/drm/tegra_drm.h:
    [...]/usr/include/drm/tegra_drm.h:21: found __[us]{8,16,32,64} type without #include <linux/types.h>

So let's include linux/types.h in this header.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Tested only with "make headers_check". I don't actually build or run
code that uses tegra_drm.h.

 include/uapi/drm/tegra_drm.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/uapi/drm/tegra_drm.h b/include/uapi/drm/tegra_drm.h
index 6e132a2..6698e81 100644
--- a/include/uapi/drm/tegra_drm.h
+++ b/include/uapi/drm/tegra_drm.h
@@ -17,6 +17,8 @@
 #ifndef _UAPI_TEGRA_DRM_H_
 #define _UAPI_TEGRA_DRM_H_
 
+#include <linux/types.h>
+
 struct drm_tegra_gem_create {
 	__u64 size;
 	__u32 flags;
-- 
1.8.1.4

Re: [PATCH] drm/tegra: Include linux/types.h

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

On Mon, Jun 17, 2013 at 01:58:14PM +0200, Paul Bolle wrote:
> "make headers_check" complains about include/uapi/drm/tegra_drm.h:
>     [...]/usr/include/drm/tegra_drm.h:21: found __[us]{8,16,32,64} type without #include <linux/types.h>
> 
> So let's include linux/types.h in this header.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Tested only with "make headers_check". I don't actually build or run
> code that uses tegra_drm.h.
> 
>  include/uapi/drm/tegra_drm.h | 2 ++
>  1 file changed, 2 insertions(+)

That has already been fixed in linux-next.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] drm/tegra: Include linux/types.h

[Paul Bolle]

On Mon, 2013-06-17 at 22:33 +0200, Thierry Reding wrote:
> That has already been fixed in linux-next.

This header was added in v3.10-rc1. The fix in linux-next will ship in
v3.11. Isn't that fix appropriate for (one of) the upcoming v3.10
release candidate(s)?

Thanks,


Paul Bolle

Re: [PATCH] drm/tegra: Include linux/types.h

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

On Mon, Jun 17, 2013 at 11:04:59PM +0200, Paul Bolle wrote:
> On Mon, 2013-06-17 at 22:33 +0200, Thierry Reding wrote:
> > That has already been fixed in linux-next.
> 
> This header was added in v3.10-rc1. The fix in linux-next will ship in
> v3.11. Isn't that fix appropriate for (one of) the upcoming v3.10
> release candidate(s)?

It's not really a bug and it can easily be worked around by including
linux/types.h explicitly. But you're right, there's still a chance of
getting this in before the final release of 3.10 and I can prepare a
pull request for Dave.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]