public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linus.walleij@stericsson.com,
	srinidhi.kasagar@stericsson.com
Subject: Re: [PATCH 2/3] ARM: ux500: Correct the EN_3v3 regulator's on/off GPIO
Date: Tue, 18 Jun 2013 15:12:58 +0200	[thread overview]
Message-ID: <201306181512.58546.arnd@arndb.de> (raw)
In-Reply-To: <1371545519-27119-3-git-send-email-lee.jones@linaro.org>

On Tuesday 18 June 2013, Lee Jones wrote:
> -                gpios = <&gpio0 26  0x4>; // 26
> -                startup-delay-us = <5000>;
> -                enable-active-high;
> +               regulator-name = "en-3v3-fixed-supply";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +               /* AB8500 GPIOs start from 1 - offset 25 is GPIO26. */
> +               gpio = <&ab8500_gpio 25 0x4>;

Is it intentional that you had "gpios" before and "gpio" after the change
as the property name?

	Arnd

  reply	other threads:[~2013-06-18 13:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18  8:51 [PATCH 0/3] ARM: ux500: mop500_snowball_ethernet_clock_enable() removal Lee Jones
2013-06-18  8:51 ` [PATCH 1/3] ARM: ux500: Provide a AB8500 GPIO Device Tree node Lee Jones
2013-06-18  8:51 ` [PATCH 2/3] ARM: ux500: Correct the EN_3v3 regulator's on/off GPIO Lee Jones
2013-06-18 13:12   ` Arnd Bergmann [this message]
2013-06-18 13:22     ` Lee Jones
2013-06-18  8:51 ` [PATCH 3/3] ARM: ux500: Remove mop500_snowball_ethernet_clock_enable() Lee Jones
2013-06-18  9:14 ` [PATCH 0/3] ARM: ux500: mop500_snowball_ethernet_clock_enable() removal Linus Walleij
2013-06-21 12:48   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201306181512.58546.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinidhi.kasagar@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox