* [PATCH] regulator: tps51632: Get regulator name from i2c_client
@ 2013-06-18 10:30 Mikko Perttunen
2013-06-18 11:44 ` Mark Brown
2013-06-18 16:00 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Mikko Perttunen @ 2013-06-18 10:30 UTC (permalink / raw)
To: broonie, wsa
Cc: linux-tegra, linux-kernel, linux-i2c, linus.walleij,
Mikko Perttunen
Commit "i2c: core: make it possible to match a pure device tree driver"
changed semantics of the i2c probing for device tree devices.
Device tree probed devices now get a NULL i2c_device_id pointer.
This causes the regulator name to be set to NULL and the regulator
registration to fail.
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
---
drivers/regulator/tps51632-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/tps51632-regulator.c b/drivers/regulator/tps51632-regulator.c
index 6e67be7..87c37f8 100644
--- a/drivers/regulator/tps51632-regulator.c
+++ b/drivers/regulator/tps51632-regulator.c
@@ -305,7 +305,7 @@ static int tps51632_probe(struct i2c_client *client,
}
tps->dev = &client->dev;
- tps->desc.name = id->name;
+ tps->desc.name = client->name;
tps->desc.id = 0;
tps->desc.ramp_delay = TPS51632_DEFAULT_RAMP_DELAY;
tps->desc.min_uV = TPS51632_MIN_VOLATGE;
--
1.8.1.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: tps51632: Get regulator name from i2c_client
2013-06-18 10:30 [PATCH] regulator: tps51632: Get regulator name from i2c_client Mikko Perttunen
@ 2013-06-18 11:44 ` Mark Brown
2013-06-18 16:00 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-06-18 11:44 UTC (permalink / raw)
To: Mikko Perttunen; +Cc: wsa, linux-tegra, linux-kernel, linux-i2c, linus.walleij
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
On Tue, Jun 18, 2013 at 01:30:13PM +0300, Mikko Perttunen wrote:
> Commit "i2c: core: make it possible to match a pure device tree driver"
> changed semantics of the i2c probing for device tree devices.
> Device tree probed devices now get a NULL i2c_device_id pointer.
> This causes the regulator name to be set to NULL and the regulator
> registration to fail.
Applied, thanks. Though it does seem like we should just be hard coding
this string anyway...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: tps51632: Get regulator name from i2c_client
2013-06-18 10:30 [PATCH] regulator: tps51632: Get regulator name from i2c_client Mikko Perttunen
2013-06-18 11:44 ` Mark Brown
@ 2013-06-18 16:00 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2013-06-18 16:00 UTC (permalink / raw)
To: Mikko Perttunen
Cc: broonie, linux-tegra, linux-kernel, linux-i2c, linus.walleij
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
On Tue, Jun 18, 2013 at 01:30:13PM +0300, Mikko Perttunen wrote:
> Commit "i2c: core: make it possible to match a pure device tree driver"
> changed semantics of the i2c probing for device tree devices.
> Device tree probed devices now get a NULL i2c_device_id pointer.
> This causes the regulator name to be set to NULL and the regulator
> registration to fail.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
The commit in question will be reverted. This patch shouldn't hurt,
though.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-18 15:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-18 10:30 [PATCH] regulator: tps51632: Get regulator name from i2c_client Mikko Perttunen
2013-06-18 11:44 ` Mark Brown
2013-06-18 16:00 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox