[PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

[PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

[Pavel Machek]

This adds ability to bind uio driver to given open firmware device
using command line option. Thus, userspace driver can be developed and
used without modifying the kernel.

Signed-off-by: Pavel Machek <pavel@denx.de> 

diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
index c122bca..8fcc2c7 100644
--- a/drivers/uio/uio_pdrv_genirq.c
+++ b/drivers/uio/uio_pdrv_genirq.c
@@ -264,9 +275,13 @@ static const struct dev_pm_ops uio_pdrv_genirq_dev_pm_ops = {
 
 #ifdef CONFIG_OF
 static const struct of_device_id uio_of_genirq_match[] = {
-	{ /* empty for now */ },
+	{ /* This is filled with module_parm */ },
+	{ /* Sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
+
+module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
+MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");
 #else
 # define uio_of_genirq_match NULL
 #endif

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

[Pavel Machek]

Hello!

> This adds ability to bind uio driver to given open firmware device
> using command line option. Thus, userspace driver can be developed and
> used without modifying the kernel.
> 
> Signed-off-by: Pavel Machek <pavel@denx.de> 

I got no comments here, and patch is pretty simple. Greg, can you
merge it?

Thanks,
									Pavel  
> 
> diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
> index c122bca..8fcc2c7 100644
> --- a/drivers/uio/uio_pdrv_genirq.c
> +++ b/drivers/uio/uio_pdrv_genirq.c
> @@ -264,9 +275,13 @@ static const struct dev_pm_ops uio_pdrv_genirq_dev_pm_ops = {
>  
>  #ifdef CONFIG_OF
>  static const struct of_device_id uio_of_genirq_match[] = {
> -	{ /* empty for now */ },
> +	{ /* This is filled with module_parm */ },
> +	{ /* Sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
> +
> +module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
> +MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");
>  #else
>  # define uio_of_genirq_match NULL
>  #endif
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

[Greg KH]

On Mon, May 06, 2013 at 12:53:52PM +0200, Pavel Machek wrote:
> Hello!
> 
> > This adds ability to bind uio driver to given open firmware device
> > using command line option. Thus, userspace driver can be developed and
> > used without modifying the kernel.
> > 
> > Signed-off-by: Pavel Machek <pavel@denx.de> 
> 
> I got no comments here, and patch is pretty simple. Greg, can you
> merge it?

Hans is handling UIO patches, Hans?

Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

[Pavel Machek]

Hi!

> This adds ability to bind uio driver to given open firmware device
> using command line option. Thus, userspace driver can be developed and
> used without modifying the kernel.
> 
> Signed-off-by: Pavel Machek <pavel@denx.de> 

Ping? Greg, could you apply this patch? Or is there someone else I
should ask to apply it?

								Pavel

> diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
> index c122bca..8fcc2c7 100644
> --- a/drivers/uio/uio_pdrv_genirq.c
> +++ b/drivers/uio/uio_pdrv_genirq.c
> @@ -264,9 +275,13 @@ static const struct dev_pm_ops uio_pdrv_genirq_dev_pm_ops = {
>  
>  #ifdef CONFIG_OF
>  static const struct of_device_id uio_of_genirq_match[] = {
> -	{ /* empty for now */ },
> +	{ /* This is filled with module_parm */ },
> +	{ /* Sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
> +
> +module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
> +MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");
>  #else
>  # define uio_of_genirq_match NULL
>  #endif
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

[Greg KH]

On Mon, Jun 17, 2013 at 03:47:41PM +0200, Pavel Machek wrote:
> Hi!
> 
> > This adds ability to bind uio driver to given open firmware device
> > using command line option. Thus, userspace driver can be developed and
> > used without modifying the kernel.
> > 
> > Signed-off-by: Pavel Machek <pavel@denx.de> 
> 
> Ping? Greg, could you apply this patch? Or is there someone else I
> should ask to apply it?

Ugh, Hans seems to have dropped off of the net for a long time now, so I
guess I'll start queueing up UIO patches again.  Care to resend this?

thanks,

greg k-h

Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

[Sachin Kamat]

Hi Greg,

On 17 June 2013 23:07, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Jun 17, 2013 at 03:47:41PM +0200, Pavel Machek wrote:
>> Hi!
>>
>> > This adds ability to bind uio driver to given open firmware device
>> > using command line option. Thus, userspace driver can be developed and
>> > used without modifying the kernel.
>> >
>> > Signed-off-by: Pavel Machek <pavel@denx.de>
>>
>> Ping? Greg, could you apply this patch? Or is there someone else I
>> should ask to apply it?
>
> Ugh, Hans seems to have dropped off of the net for a long time now, so I
> guess I'll start queueing up UIO patches again.  Care to resend this?
>

Even I have a couple of outstanding UIO patches [1-2]. Shall I resend
them as well?

[1] https://lkml.org/lkml/2013/3/14/154
[2] https://patchwork.kernel.org/patch/2268921/


-- 
With warm regards,
Sachin

Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

[Pavel Machek]

On Mon 2013-06-17 10:37:38, Greg KH wrote:
> On Mon, Jun 17, 2013 at 03:47:41PM +0200, Pavel Machek wrote:
> > Hi!
> > 
> > > This adds ability to bind uio driver to given open firmware device
> > > using command line option. Thus, userspace driver can be developed and
> > > used without modifying the kernel.
> > > 
> > > Signed-off-by: Pavel Machek <pavel@denx.de> 
> > 
> > Ping? Greg, could you apply this patch? Or is there someone else I
> > should ask to apply it?
> 
> Ugh, Hans seems to have dropped off of the net for a long time now, so I
> guess I'll start queueing up UIO patches again.  Care to resend this?

Here you go. It still applies to your -next tree.

Thanks,
								Pavel
---

This adds ability to bind uio driver to given open firmware device
using command line option. Thus, userspace driver can be developed and
used without modifying the kernel.

Signed-off-by: Pavel Machek <pavel@denx.de> 
Tested-by: Detlev Zundel <dzu@denx.de>

diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
index c122bca..8fcc2c7 100644
--- a/drivers/uio/uio_pdrv_genirq.c
+++ b/drivers/uio/uio_pdrv_genirq.c
@@ -264,9 +275,13 @@ static const struct dev_pm_ops uio_pdrv_genirq_dev_pm_ops = {
 
 #ifdef CONFIG_OF
 static const struct of_device_id uio_of_genirq_match[] = {
-	{ /* empty for now */ },
+	{ /* This is filled with module_parm */ },
+	{ /* Sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
+
+module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
+MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");
 #else
 # define uio_of_genirq_match NULL
 #endif

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

[Pavel Machek]

On Tue 2013-06-18 15:02:16, Pavel Machek wrote:
> On Mon 2013-06-17 10:37:38, Greg KH wrote:
> > On Mon, Jun 17, 2013 at 03:47:41PM +0200, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > This adds ability to bind uio driver to given open firmware device
> > > > using command line option. Thus, userspace driver can be developed and
> > > > used without modifying the kernel.
> > > > 
> > > > Signed-off-by: Pavel Machek <pavel@denx.de> 
> > > 
> > > Ping? Greg, could you apply this patch? Or is there someone else I
> > > should ask to apply it?
> > 
> > Ugh, Hans seems to have dropped off of the net for a long time now, so I
> > guess I'll start queueing up UIO patches again.  Care to resend this?
> 
> Here you go. It still applies to your -next tree.

And here's version that removes "const" that is no longer true. I
missed the compile warning before. Sorry,
								Pavel

-(cut here)-

This adds ability to bind uio driver to given open firmware device
using command line option. Thus, userspace driver can be developed and
used without modifying the kernel.

Signed-off-by: Pavel Machek <pavel@denx.de>
Tested-by: Detlev Zundel <dzu@denx.de>

diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
index d594dd9..9741549 100644
--- a/drivers/uio/uio_pdrv_genirq.c
+++ b/drivers/uio/uio_pdrv_genirq.c
@@ -258,10 +258,14 @@ static const struct dev_pm_ops uio_pdrv_genirq_dev_pm_ops = {
 };
 
 #ifdef CONFIG_OF
-static const struct of_device_id uio_of_genirq_match[] = {
-	{ /* empty for now */ },
+static struct of_device_id uio_of_genirq_match[] = {
+	{ /* This is filled with module_parm */ },
+	{ /* Sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
+
+module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
+MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");
 #else
 # define uio_of_genirq_match NULL
 #endif


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

[Greg KH]

On Tue, Jun 18, 2013 at 10:32:33AM +0530, Sachin Kamat wrote:
> Hi Greg,
> 
> On 17 June 2013 23:07, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Mon, Jun 17, 2013 at 03:47:41PM +0200, Pavel Machek wrote:
> >> Hi!
> >>
> >> > This adds ability to bind uio driver to given open firmware device
> >> > using command line option. Thus, userspace driver can be developed and
> >> > used without modifying the kernel.
> >> >
> >> > Signed-off-by: Pavel Machek <pavel@denx.de>
> >>
> >> Ping? Greg, could you apply this patch? Or is there someone else I
> >> should ask to apply it?
> >
> > Ugh, Hans seems to have dropped off of the net for a long time now, so I
> > guess I'll start queueing up UIO patches again.  Care to resend this?
> >
> 
> Even I have a couple of outstanding UIO patches [1-2]. Shall I resend
> them as well?
> 
> [1] https://lkml.org/lkml/2013/3/14/154
> [2] https://patchwork.kernel.org/patch/2268921/

Yes, please do.

thanks,

greg k-h

Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

[Greg KH]

On Tue, Jun 18, 2013 at 04:30:43PM +0200, Pavel Machek wrote:
> On Tue 2013-06-18 15:02:16, Pavel Machek wrote:
> > On Mon 2013-06-17 10:37:38, Greg KH wrote:
> > > On Mon, Jun 17, 2013 at 03:47:41PM +0200, Pavel Machek wrote:
> > > > Hi!
> > > > 
> > > > > This adds ability to bind uio driver to given open firmware device
> > > > > using command line option. Thus, userspace driver can be developed and
> > > > > used without modifying the kernel.
> > > > > 
> > > > > Signed-off-by: Pavel Machek <pavel@denx.de> 
> > > > 
> > > > Ping? Greg, could you apply this patch? Or is there someone else I
> > > > should ask to apply it?
> > > 
> > > Ugh, Hans seems to have dropped off of the net for a long time now, so I
> > > guess I'll start queueing up UIO patches again.  Care to resend this?
> > 
> > Here you go. It still applies to your -next tree.
> 
> And here's version that removes "const" that is no longer true. I
> missed the compile warning before. Sorry,
> 								Pavel
> 
> -(cut here)-

Please resend in a format that I don't have to edit by hand.

greg k-h