Re: [PATCH v4 5/7] cpufreq: Calculate number of busy CPUs

Lukasz Majewski
2013-07-01T08:15:30Z

On Fri, 28 Jun 2013 08:54:57 +0200, Lukasz Majewski wrote:
> > > So thermal or "other solution" [*] shall disable boost when
> > > overheated and enable it back when things cool down.
> >
> > yeah..
>
> For me thermal is a good candidate to enable boost again. I only need
> to find a proper place for it.

Unfortunately, after careful investigation it turned out, that thermal
is suited to disable boost when overheating is detected. (since it uses
thermal subsystem interrupt to take action).

The problem is with enabling boost again, since thermal (at least at my
board) only reacts on TMU (thermal) interrupt. Thermal thread may be
started, but I don't regard this as a good solution (to extra bloat
thermal).

>
> >
> > > [*] @ Viresh & Rafael do you have any idea about the "other
> > > solution" here?
> >
> > Not really sure :)
>
> Not any single one? Then I would like to propose thermal.
>

Does anybody have any idea here? As written above, thermal is suitable
to disable boost.

I'd like to bring those three options under discussion:

1. boost attr is always exported -> do not enable boost automatically
when disabled by thermal (as it was proposed at v4).

2. boost attr is always exported -> find a way to enable boost after
emergency disablement when thermal detects overheating (newest
proposition).

3. boost attr only exported at x86 (when supported)
boost attr NOT exported via sysfs for SW controlled boost (e.g.
Exynos ARM).

Then we only enable/disable boost at kernel and don't need to take
care of the user space interaction. This scenario is my use case. I
hadn't planned to expose boost to userspace and use it with LAB as a
kernel API.

--
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group