From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934424Ab3FSJtA (ORCPT ); Wed, 19 Jun 2013 05:49:00 -0400 Received: from mail-bk0-f41.google.com ([209.85.214.41]:35870 "EHLO mail-bk0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934057Ab3FSJs5 (ORCPT ); Wed, 19 Jun 2013 05:48:57 -0400 Date: Wed, 19 Jun 2013 10:48:50 +0100 From: Lee Jones To: Samuel Ortiz Cc: Tuomas Tynkkynen , Mark Brown , Wolfram Sang , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe Message-ID: <20130619094850.GF22998@laptop> References: <1371550481-28126-1-git-send-email-ttynkkynen@nvidia.com> <1371550481-28126-2-git-send-email-ttynkkynen@nvidia.com> <20130619081859.GA22998@laptop> <20130619082740.GT7161@zurbaran> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130619082740.GT7161@zurbaran> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jun 2013, Samuel Ortiz wrote: > Hi Lee, > > On Wed, Jun 19, 2013 at 09:18:59AM +0100, Lee Jones wrote: > > On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > > > > > Commit "i2c: core: make it possible to match a pure device tree driver" > > > changed semantics of the i2c probing for device tree devices. > > > Device tree probed devices now get a NULL i2c_device_id pointer. > > > This caused kernel panics due to NULL dereference. > > > > > > Moves the of_match_device call from tps65910_parse_dt to .probe to > > > allow the chip type to be detected from device tree but with the > > > device parameters coming from platform data. > > > > > > Signed-off-by: Tuomas Tynkkynen > > > > Applied with Stephen's Reviewed-by, thanks. > According to Wolfgang, this is not needed as he will revert the i2c > commits that are causing those crashes. > I would not take it for now. Fair enough. Unapplied. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog