From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935689Ab3FTDTI (ORCPT ); Wed, 19 Jun 2013 23:19:08 -0400 Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:53394 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935537Ab3FTDTF (ORCPT ); Wed, 19 Jun 2013 23:19:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0lAIZzwlF5LHzo/2dsb2JhbABagwkxgmKpCI5UhSAEAXwXdIIjAQEFOhwjEAgDGAklDwUlAyETiA28HRaOD4EdB4NhA5dAkUWDISo Date: Thu, 20 Jun 2013 13:18:59 +1000 From: Dave Chinner To: Sage Weil Cc: Li Wang , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Yunchuan Wen , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2] Ceph: Punch hole support Message-ID: <20130620031859.GP29338@dastard> References: <1371224186-4809-1-git-send-email-liwang@ubuntukylin.com> <1371224340-4926-1-git-send-email-liwang@ubuntukylin.com> <51C1DB17.6040803@ubuntukylin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 19, 2013 at 09:31:21AM -0700, Sage Weil wrote: > Hi Li, > > There is a version of fsx.c floating around that tests hole punching... > have you tried running that on top of this patch? Ideally, we should > build a test (ceph.git/qa/workunits/rbd/hole_punch.sh or similar) that > tests the hole punch both with a default file layout and with a more > complicated striping pattern (e.g. object_size=1048576 stripe_unit=65536 > stripe_count=7). The version in xfstests has hole punch support, as does the version of fsstress. There are also some corner case tests for punch behaviour, so running the generic tests in xfstests should shake out most bugs.... Cheers, Dave. -- Dave Chinner david@fromorbit.com