From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-mips@linux-mips.org, David Daney <david.daney@cavium.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Fix OCTEON BUG() warnings a different way.
Date: Thu, 20 Jun 2013 16:26:25 +0200 [thread overview]
Message-ID: <20130620142625.GA30061@linux-mips.org> (raw)
In-Reply-To: <1371679468-29479-1-git-send-email-ddaney.cavm@gmail.com>
On Wed, Jun 19, 2013 at 03:04:28PM -0700, David Daney wrote:
> Signed-off-by: David Daney <david.daney@cavium.com>
I replaced my fix with your fix but left he direct inclusion of
<linux/bug.h>.
Let as homework for a later point: make BUG() invoke unreachable() if
CONFIG_BUG is diabled, something like that. This will improve code
generation for GCC 4.5+ but for older compilers unreachable() is
defined as do { } while (1) so will emit extra code.
Thanks,
Ralf
parent reply other threads:[~2013-06-20 14:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1371679468-29479-1-git-send-email-ddaney.cavm@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620142625.GA30061@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox