linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Matthew Garrett <mjg59@srcf.ucam.org>, "H. Peter Anvin" <hpa@zytor.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Ingo Molnar <mingo@kernel.org>,
	Linux EFI <linux-efi@vger.kernel.org>,
	Matt Fleming <matt@console-pimps.org>, X86 ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH -v2 0/4] EFI 1:1 mapping
Date: Thu, 20 Jun 2013 20:47:36 +0200	[thread overview]
Message-ID: <20130620184736.GC19877@pd.tnic> (raw)
In-Reply-To: <20130620181731.GA27960@srcf.ucam.org>

On Thu, Jun 20, 2013 at 07:17:31PM +0100, Matthew Garrett wrote:
> On Thu, Jun 20, 2013 at 08:14:45PM +0200, Borislav Petkov wrote:
> > On Thu, Jun 20, 2013 at 07:10:15PM +0100, Matthew Garrett wrote:
> > > Because Windows passes high addresses to SetVirtualAddressMap(), and
> > > because if you can imagine firmware developers getting it wrong then
> > > firmware developers will have got it wrong.
> > 
> > Can we reversely assume that if we'd used fixed high offsets, as hpa
> > suggests, then it'll be fine? IOW, are any high addresses, even fixed
> > ones, fine?
> 
> Windows actually seems to start at the top of address space and go down 
> - this is what I get booting Windows 8 under kvm. It looks like very 
> high addresses are fine, and we're currently using "low" high addresses, 
> so I suspect we're fine pretty much anywhere in that range.
> 
> ****** SetVirtualAddressMap
> Type: 5
> Physical Start: 3E878000
> Virtual Start: FFFFFFFFFFBEB000
> Number Of Pages: 15
> Attributes: 800000000000000F
> Type: 6
> Physical Start: 3E88D000
> Virtual Start: FFFFFFFFFFBD6000
> Number Of Pages: 15
> Attributes: 800000000000000F
> Type: 5
> Physical Start: 3FB22000
> Virtual Start: FFFFFFFFFFBA6000
> Number Of Pages: 30
> Attributes: 800000000000000F
> Type: 6
> Physical Start: 3FB52000
> Virtual Start: FFFFFFFFFFB82000
> Number Of Pages: 24
> Attributes: 800000000000000F
> Type: 6
> Physical Start: 3FFE0000
> Virtual Start: FFFFFFFFFFB62000
> Number Of Pages: 20

I guess we can do a top-down allocation, starting from the highest
virtual addresses:

EFI_HIGHEST_ADDRESS
|
| size1
|
--> region1
|
| size2
|
--> region2

...

and we make EFI_HIGHEST_ADDRESS be the same absolute number on every
system.

hpa, is this close to what you had in mind? It would be prudent to
verify whether this will suit well with the kexec virtual space layout
though...

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2013-06-20 18:47 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 17:50 [PATCH -v2 0/4] EFI 1:1 mapping Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 1/4] efi: Convert runtime services function ptrs Borislav Petkov
2013-06-20 18:15   ` [PATCH] [IA64] sim: Add casts to avoid assignment warnings Luck, Tony
2013-06-20 23:43     ` Tony Luck
2013-06-21 10:26       ` Fleming, Matt
2013-06-17 17:50 ` [PATCH -v2 2/4] x86, cpa: Map in an arbitrary pgd Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 3/4] x86, efi: Add an efi= kernel command line parameter Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 4/4] x86, efi: Map runtime services 1:1 Borislav Petkov
2013-06-21 11:56   ` Matt Fleming
2013-07-03  6:19   ` joeyli
2013-06-19 12:52 ` [PATCH -v2 0/4] EFI 1:1 mapping Ingo Molnar
2013-06-19 13:02   ` Borislav Petkov
2013-06-19 13:04     ` Ingo Molnar
2013-06-19 13:25       ` Borislav Petkov
2013-06-19 16:08       ` Matthew Garrett
2013-06-19 16:18         ` Borislav Petkov
2013-06-19 16:21           ` Matthew Garrett
2013-06-19 16:38             ` Borislav Petkov
2013-06-19 16:48               ` Matthew Garrett
2013-06-19 16:59                 ` Borislav Petkov
2013-06-20 21:26                   ` H. Peter Anvin
2013-06-21  6:34                   ` Matt Fleming
2013-06-19 16:50               ` James Bottomley
2013-06-20  9:13         ` Ingo Molnar
2013-06-20  9:15           ` Matthew Garrett
2013-06-20  9:22             ` Ingo Molnar
2013-06-20  9:33               ` Borislav Petkov
2013-06-20  9:44                 ` Matthew Garrett
2013-06-20 14:33                   ` Jiri Kosina
2013-06-20 14:53                   ` James Bottomley
2013-06-20 16:29                     ` Matthew Garrett
2013-06-20 16:44                       ` Jiri Kosina
2013-06-20 16:53                         ` Matthew Garrett
2013-06-20 16:46                       ` James Bottomley
2013-06-20 16:54                         ` Matthew Garrett
2013-06-20 17:01                           ` Borislav Petkov
2013-06-20 17:12                             ` Matthew Garrett
2013-06-20 18:08                               ` Borislav Petkov
2013-06-20 18:10                                 ` Matthew Garrett
2013-06-20 18:14                                   ` Borislav Petkov
2013-06-20 18:17                                     ` Matthew Garrett
2013-06-20 18:47                                       ` Borislav Petkov [this message]
2013-06-20 22:35                                         ` H. Peter Anvin
2013-06-21  7:23                                           ` Borislav Petkov
2013-06-21 10:05                                             ` H. Peter Anvin
2013-06-21 14:21                                               ` Borislav Petkov
2013-06-21 16:42                                                 ` H. Peter Anvin
2013-07-02  7:29                                                   ` Pavel Machek
2013-06-19 16:05     ` Matthew Garrett
2013-06-19 17:25     ` H. Peter Anvin
2013-06-19 17:37       ` Borislav Petkov
2013-06-19 17:38         ` H. Peter Anvin
2013-06-19 17:50           ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130620184736.GC19877@pd.tnic \
    --to=bp@alien8.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@console-pimps.org \
    --cc=mingo@kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).