From: Alasdair G Kergon <agk@redhat.com>
To: Geremy Condra <gcondra@google.com>
Cc: dm-devel@redhat.com, wad@chromium.org,
linux-kernel@vger.kernel.org, agk@redhat.com
Subject: Re: [dm-devel] [PATCH] dm: verity: Add support for emitting uevents on dm-verity errors.
Date: Fri, 21 Jun 2013 01:59:05 +0100 [thread overview]
Message-ID: <20130621005905.GI23042@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <1371763260-9933-1-git-send-email-gcondra@google.com>
On Thu, Jun 20, 2013 at 02:21:00PM -0700, Geremy Condra wrote:
> With this change and config option, dm-verity errors
> will cause uevents to be sent to userspace, notifying
> it that an error has occurred and potentially
> triggering recovery actions.
> +config DM_VERITY_ERROR_NOTIFY
> + tristate "Notify userspace of verity errors through uevents"
> + depends on DM_VERITY && DM_UEVENT
> + ---help---
> + This option instructs dm-verity to send uevents on error.
> +
Would it cause any problems if we had this feature enabled all the time,
controlled only by DM_UEVENT?
In other words, if we delete DM_VERITY_ERROR_NOTIFY from the upstream patch?
Alasdair
next prev parent reply other threads:[~2013-06-21 0:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 21:21 [PATCH] dm: verity: Add support for emitting uevents on dm-verity errors Geremy Condra
2013-06-21 0:59 ` Alasdair G Kergon [this message]
[not found] ` <CAEQjtanyk2mw2LHMruU+4ujj4KsTtgyfh=3ABk+3g77Bn-6W3g@mail.gmail.com>
2013-06-21 1:30 ` [dm-devel] " Alasdair G Kergon
2013-06-21 3:00 ` Geremy Condra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130621005905.GI23042@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=gcondra@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).