From: Ingo Molnar <mingo@kernel.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Greg KH <greg@kroah.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: Status of __cpuinit removal
Date: Sun, 23 Jun 2013 12:15:59 +0200 [thread overview]
Message-ID: <20130623101559.GC19021@gmail.com> (raw)
In-Reply-To: <20130620174659.GA17945@windriver.com>
* Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> As some of you are probably aware, a decision to remove __cpuinit and
> variants was made, since the cost/complexity outweighs the amount of
> memory reclaim that it provides. Details of that decision are at:
>
> https://lkml.org/lkml/2013/5/20/589
>
> It seems that the suggestion to do this was partly motivated by the
> fix in commit 5e427ec2 ("x86: Fix bit corruption at CPU resume time").
> It is a good example of the nasty type of bugs that can be created
> with improper use of the various types of __init prefixes.
>
> I have created a patch queue against the latest linux-next tree (Jun20)
> that removes all the variants of __cpuinit and the asm __CPUINIT variants,
> and the surrounding infrastructure for section handling of it. There
> are no Kconfig changes; this is complex enough. We can independently
> revisit later whether keeping CPU_HOTPLUG makes sense or not.
>
> I have done this in 33 commits. I decided against a giant monolithic
> patch for several reasons:
[...]
> scripts/mod/modpost.c | 52 ++++------------------
> 307 files changed, 895 insertions(+), 1036 deletions(-)
Cool, thanks Paul for addressing all this!
Thanks,
Ingo
next prev parent reply other threads:[~2013-06-23 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 22:35 Get rid of cpuinit? H. Peter Anvin
2013-05-20 23:12 ` Greg KH
2013-05-28 9:20 ` Ingo Molnar
2013-06-12 0:31 ` Paul Gortmaker
2013-06-12 0:56 ` Greg KH
2013-06-20 17:46 ` Status of __cpuinit removal Paul Gortmaker
2013-06-21 1:32 ` Greg KH
2013-06-23 10:15 ` Ingo Molnar [this message]
2013-05-22 21:04 ` Get rid of cpuinit? Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130623101559.GC19021@gmail.com \
--to=mingo@kernel.org \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).