From: "Heiko Stübner" <heiko@sntech.de>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: rockchip: Add missing irq_gc_unlock() call before return error
Date: Sun, 23 Jun 2013 10:26:28 +0200 [thread overview]
Message-ID: <201306231026.29244.heiko@sntech.de> (raw)
In-Reply-To: <1371948514.9509.1.camel@phoenix>
Am Sonntag, 23. Juni 2013, 02:48:34 schrieb Axel Lin:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Thanks for catching this glitch.
Acked-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/pinctrl/pinctrl-rockchip.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index 427564f..1eb5a2e 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1035,6 +1035,7 @@ static int rockchip_irq_set_type(struct irq_data *d,
> unsigned int type) polarity &= ~mask;
> break;
> default:
> + irq_gc_unlock(gc);
> return -EINVAL;
> }
next prev parent reply other threads:[~2013-06-23 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 0:48 [PATCH] pinctrl: rockchip: Add missing irq_gc_unlock() call before return error Axel Lin
2013-06-23 8:26 ` Heiko Stübner [this message]
2013-06-24 12:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306231026.29244.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=axel.lin@ingics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox