* [PATCH] tpm: tpm_i2c_infinion: Don't modify i2c_client->driver
@ 2013-06-15 14:23 Lars-Peter Clausen
2013-06-23 23:16 ` [tpmdd-devel] " Peter Hüwe
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2013-06-15 14:23 UTC (permalink / raw)
To: Kent Yoder; +Cc: Peter Huewe, tpmdd-devel, linux-kernel, Lars-Peter Clausen
The I2C client driver is not supposed to modify the client's driver pointer,
this is handled by the I2C core.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/char/tpm/tpm_i2c_infineon.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c
index 37d5dcc..dbc7042 100644
--- a/drivers/char/tpm/tpm_i2c_infineon.c
+++ b/drivers/char/tpm/tpm_i2c_infineon.c
@@ -74,7 +74,6 @@ struct tpm_inf_dev {
};
static struct tpm_inf_dev tpm_dev;
-static struct i2c_driver tpm_tis_i2c_driver;
/*
* iic_tpm_read() - read from TPM register
@@ -744,11 +743,9 @@ static int tpm_tis_i2c_probe(struct i2c_client *client,
return -ENODEV;
}
- client->driver = &tpm_tis_i2c_driver;
tpm_dev.client = client;
rc = tpm_tis_i2c_init(&client->dev);
if (rc != 0) {
- client->driver = NULL;
tpm_dev.client = NULL;
rc = -ENODEV;
}
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [tpmdd-devel] [PATCH] tpm: tpm_i2c_infinion: Don't modify i2c_client->driver
2013-06-15 14:23 [PATCH] tpm: tpm_i2c_infinion: Don't modify i2c_client->driver Lars-Peter Clausen
@ 2013-06-23 23:16 ` Peter Hüwe
0 siblings, 0 replies; 2+ messages in thread
From: Peter Hüwe @ 2013-06-23 23:16 UTC (permalink / raw)
To: tpmdd-devel, Peter Huewe; +Cc: Lars-Peter Clausen, linux-kernel, shpedoikal
Am Samstag, 15. Juni 2013, 16:23:24 schrieb Lars-Peter Clausen:
> The I2C client driver is not supposed to modify the client's driver
> pointer, this is handled by the I2C core.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
Nice catch.
Staged here:
https://github.com/PeterHuewe/linux-tpmdd/commits/for-james
Thanks,
Peter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-23 23:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-15 14:23 [PATCH] tpm: tpm_i2c_infinion: Don't modify i2c_client->driver Lars-Peter Clausen
2013-06-23 23:16 ` [tpmdd-devel] " Peter Hüwe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox