From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799Ab3FYGsj (ORCPT ); Tue, 25 Jun 2013 02:48:39 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:48901 "EHLO e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751572Ab3FYGsh (ORCPT ); Tue, 25 Jun 2013 02:48:37 -0400 Date: Tue, 25 Jun 2013 08:48:32 +0200 From: Heiko Carstens To: Chen Gang Cc: Martin Schwidefsky , linux390@de.ibm.com, cornelia.huck@de.ibm.com, mtosatti@redhat.com, Thomas Gleixner , linux-s390@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux-Arch Subject: Re: [PATCH] arch: s390: kernel: reset 'c->hotpluggable' when failure occurs Message-ID: <20130625064832.GA4999@osiris> References: <51C8F685.6000209@asianux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51C8F685.6000209@asianux.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13062506-2966-0000-0000-000007F6FDE8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 25, 2013 at 09:46:45AM +0800, Chen Gang wrote: > When smp_add_present_cpu() fails, it has reset all things excluding > 'c->hotpluggable', so need reset it as original state completely. > > Signed-off-by: Chen Gang > --- > arch/s390/kernel/smp.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c > index 15a016c..c4c6f42 100644 > --- a/arch/s390/kernel/smp.c > +++ b/arch/s390/kernel/smp.c > @@ -1016,6 +1016,7 @@ out_cpu: > unregister_cpu(c); > #endif > out: > + c->hotpluggable = 0; > return rc; No, that doesn't make sense. All cpus on s390 are always hotplugable. It really doesn't matter if the value of this field is 0 or 1 after an error.