From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751774Ab3FZPN0 (ORCPT ); Wed, 26 Jun 2013 11:13:26 -0400 Received: from mail.free-electrons.com ([94.23.35.102]:49027 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349Ab3FZPNZ (ORCPT ); Wed, 26 Jun 2013 11:13:25 -0400 Date: Wed, 26 Jun 2013 17:13:21 +0200 From: Maxime Ripard To: Alexandre Belloni Cc: Shawn Guo , Russell King , jimwall@q.com, brian@crystalfontz.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree Message-ID: <20130626151321.GD5803@lukather> References: <1372258347-18422-1-git-send-email-alexandre.belloni@free-electrons.com> <1372258347-18422-3-git-send-email-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9dgjiU4MmWPVapMU" Content-Disposition: inline In-Reply-To: <1372258347-18422-3-git-send-email-alexandre.belloni@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --9dgjiU4MmWPVapMU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Alexandre, On Wed, Jun 26, 2013 at 04:52:26PM +0200, Alexandre Belloni wrote: > From: Brian Lilly >=20 > The CFA-10056 is a breakout board for the CFA-10036, and is > basically a CFA-10037, with ai 4.3" screen. ^ typo > Signed-off-by: Brian Lilly > Signed-off-by: Alexandre Belloni > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx28-cfa10056.dts | 200 +++++++++++++++++++++++++++++= ++++++ > 2 files changed, 201 insertions(+) > create mode 100644 arch/arm/boot/dts/imx28-cfa10056.dts >=20 > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 225d939..d494f37 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXS) +=3D imx23-evk.dtb \ > imx28-cfa10037.dtb \ > imx28-cfa10049.dtb \ > imx28-cfa10055.dtb \ > + imx28-cfa10056.dtb \ > imx28-cfa10057.dtb \ > imx28-evk.dtb \ > imx28-m28evk.dtb \ > diff --git a/arch/arm/boot/dts/imx28-cfa10056.dts b/arch/arm/boot/dts/imx= 28-cfa10056.dts > new file mode 100644 > index 0000000..47b5016 > --- /dev/null > +++ b/arch/arm/boot/dts/imx28-cfa10056.dts > @@ -0,0 +1,200 @@ > +/* > + * Copyright 2012 Free Electrons > + * > + * The code contained herein is licensed under the GNU General Public > + * License. You may obtain a copy of the GNU General Public License > + * Version 2 or later at the following locations: > + * > + * http://www.opensource.org/licenses/gpl-license.html > + * http://www.gnu.org/copyleft/gpl.html > + */ > + > +/* > + * The CFA-10056 is an expansion board for the CFA-10036 module, thus we > + * need to include the CFA-10036 DTS. > + */ > +/include/ "imx28-cfa10036.dts" > + > +/ { > + model =3D "Crystalfontz CFA-10056 Board"; > + compatible =3D "crystalfontz,cfa10056", "crystalfontz,cfa10036", "fsl,i= mx28"; > + > + apb@80000000 { > + apbh@80000000 { > + pinctrl@80018000 { > + pinctrl-names =3D "default", "default"; > + pinctrl-1 =3D <&hog_pins_cfa10056 > + &hog_pins_cfa10056_pullup>; > + > + hog_pins_cfa10056: hog-10056@0 { > + reg =3D <0>; > + fsl,pinmux-ids =3D < > + 0x0073 /* MX28_PAD_GPMI_D7__GPIO_0_7 */ > + 0x2153 /* MX28_PAD_SSP2_D5__GPIO_2_21 */ > + 0x3053 /* MX28_PAD_AUART1_TX__GPIO_3_5 */ > + >; > + fsl,drive-strength =3D <0>; > + fsl,voltage =3D <1>; > + fsl,pull-up =3D <0>; > + }; > + > + hog_pins_cfa10056_pullup: hog-10056-pullup@0 { > + reg =3D <0>; > + fsl,pinmux-ids =3D < > + 0x2133 /* MX28_PAD_SSP2_D3__GPIO_2_19 */ > + 0x3183 /* MX28_PAD_I2C0_SCL__GPIO_3_24 */ > + 0x3193 /* MX28_PAD_I2C0_SDA__GPIO_3_25 */ > + 0x31a3 /* MX28_PAD_SAIF_SDATA0__GPIO_3_26 */ > + 0x31e3 /* MX28_PAD_LCD_RESET__GPIO_3_30 */ > + >; > + fsl,drive-strength =3D <0>; > + fsl,voltage =3D <1>; > + fsl,pull-up =3D <1>; > + }; These pins don't seem used in your DT. Are you sure you need them? > + spi2_pins_cfa10056: spi2-cfa10056@0 { > + reg =3D <0>; > + fsl,pinmux-ids =3D < > + 0x2103 /* MX28_PAD_SSP2_SCK__GPIO_2_16 */ > + 0x2113 /* MX28_PAD_SSP2_CMD__GPIO_2_17 */ > + 0x2123 /* MX28_PAD_SSP2_D0__GPIO_2_18 */ > + >; > + fsl,drive-strength =3D <1>; > + fsl,voltage =3D <1>; > + fsl,pull-up =3D <1>; > + }; > + > + spi3_pins_cfa10056: spi3-cfa10056@0 { > + reg =3D <0>; > + fsl,pinmux-ids =3D < > + 0x0183 /* MX28_PAD_GPMI_RDN__GPIO_0_24 */ > + 0x01c3 /* MX28_PAD_GPMI_RESETN__GPIO_0_28 */ > + 0x0113 /* MX28_PAD_GPMI_CE1N__GPIO_0_17 */ > + 0x01a3 /* MX28_PAD_GPMI_ALE__GPIO_0_26 */ > + 0x01b3 /* MX28_PAD_GPMI_CLE__GPIO_0_27 */ > + >; > + fsl,drive-strength =3D <1>; > + fsl,voltage =3D <1>; > + fsl,pull-up =3D <1>; > + }; Ditto. > + lcdif_pins_cfa10056: lcdif-evk@0 { > + reg =3D <0>; > + fsl,pinmux-ids =3D < > + 0x1181 /* MX28_PAD_LCD_RD_E__LCD_VSYNC */ > + 0x1191 /* MX28_PAD_LCD_WR_RWN__LCD_HSYNC */ > + 0x11a1 /* MX28_PAD_LCD_RS__LCD_DOTCLK */ > + 0x11b1 /* MX28_PAD_LCD_CS__LCD_ENABLE */ > + >; > + fsl,drive-strength =3D <0>; > + fsl,voltage =3D <1>; > + fsl,pull-up =3D <0>; > + }; > + }; > + > + lcdif@80030000 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&lcdif_24bit_pins_a > + &lcdif_pins_cfa10056>; > + display =3D <&display>; > + status =3D "okay"; > + > + display: display { > + bits-per-pixel =3D <32>; > + bus-width =3D <24>; > + > + display-timings { > + native-mode =3D <&timing0>; > + timing0: timing0 { > + clock-frequency =3D <32000000>; > + hactive =3D <480>; > + vactive =3D <800>; > + hback-porch =3D <2>; > + hfront-porch =3D <2>; > + vback-porch =3D <2>; > + vfront-porch =3D <2>; > + hsync-len =3D <5>; > + vsync-len =3D <5>; > + hsync-active =3D <0>; > + vsync-active =3D <0>; > + de-active =3D <1>; > + pixelclk-active =3D <1>; > + }; > + }; > + }; > + }; > + }; > + > + apbx@80040000 { > + i2c1: i2c@8005a000 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c1_pins_a>; > + status =3D "okay"; > + }; There's no child device on this bus. We don't need to load it (and we can remove the pinctrl node with it as well). > + usbphy1: usbphy@8007e000 { > + status =3D "okay"; > + }; > + }; > + }; > + > + ahb@80080000 { > + usb1: usb@80090000 { > + vbus-supply =3D <®_usb1_vbus>; > + pinctrl-0 =3D <&usbphy1_pins_a>; > + pinctrl-names =3D "default"; > + status =3D "okay"; > + }; > + }; > + > + regulators { > + compatible =3D "simple-bus"; > + > + reg_usb1_vbus: usb1_vbus { > + compatible =3D "regulator-fixed"; > + regulator-name =3D "usb1_vbus"; > + regulator-min-microvolt =3D <5000000>; > + regulator-max-microvolt =3D <5000000>; > + gpio =3D <&gpio0 7 1>; > + }; > + }; > + > + ahb@80080000 { > + mac0: ethernet@800f0000 { > + phy-mode =3D "rmii"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&mac0_pins_a>; > + phy-reset-gpios =3D <&gpio2 21 0>; > + phy-reset-duration =3D <100>; > + status =3D "okay"; > + }; > + }; > + > + spi2 { > + compatible =3D "spi-gpio"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&spi2_pins_cfa10056>; > + status =3D "okay"; > + gpio-sck =3D <&gpio2 16 0>; > + gpio-mosi =3D <&gpio2 17 0>; > + gpio-miso =3D <&gpio2 18 0>; > + cs-gpios =3D <&gpio3 5 0>; > + num-chipselects =3D <1>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + hx8369: hx8369@0 { > + compatible =3D "himax,hx8369a", "himax,hx8369"; > + reg =3D <0>; > + spi-max-frequency =3D <100000>; > + spi-cpol; > + spi-cpha; > + gpios-reset =3D <&gpio3 30 0>; > + }; > + }; > + > + fiq { > + compatible =3D "crystalfontz,cfa10049-fiq"; > + interrupts =3D <50>; > + }; > +}; This code has never been merged, and even with the unmerged driver the driver won't load. You should maybe remove it :) Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --9dgjiU4MmWPVapMU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJRywURAAoJEBx+YmzsjxAg2OUP/2zNdPZMZTEW3t7J3289DXm2 VFWDu7CvRSIxhjlxG3NHIQwFXrVFl/TFvK3OQfS3+C9ZYxaidQawAQKaqkCE4bu3 u9YDSfa0MkNIN/qSiI6VndLVyKZ/6yAqkl6lCOYzRtvnzCZh37q7Ou+of71cIyCU scURBB2tbz/J5zsQh8bmJYXt8c8VBxFAxWmNacs2HstK1YcL+q9lq56EeBDSyVfp /oRbvSb/elN6RblOMzHaMHdXt8OPR1rJVGvxX5jm6i7+orFOhloyg/ehsrtu4lcQ EvCtwm9Mw4AWgrSSZIJE22vEhbXgl0Mu6pWH0aRwqqjQvlrfZ6/WYrYxrtiGHFT8 +/VYIdsZe7H6ocmNhPSxw+7/W3KGWRfAjOserBJciu1g8+KuggoSuIo43wBDGRH/ ZA0hTnI9MZqvQAuu+o/OwxoC6Xb0scj3cZO2CnZxfYxFRGGrhOZDk2WYvjkjpG28 Q2RyhXJfc3CvDRjnhqDMeE7J3myYitWTUnTV4RrVDxA3ENwl/ogVm6hCuEt6mNjP et7sl4ZLreYzn7h/Wjzb7slbPZTAFD1WX4ZFoHi6UGxVlwScDjr58ZOkZycWE/9J hHUIcJ/9tv/Ou2iUEHf+kLpJsA7p40XMAs87ypQX8lHKQQAtJEzsh+0sq0zND4Um R3gW5Z47RcEkaXyuTkFn =yNNd -----END PGP SIGNATURE----- --9dgjiU4MmWPVapMU--