public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Mike Galbraith <bitbucket@online.de>,
	Dave Chiluk <chiluk@canonical.com>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Scheduler accounting inflated for io bound processes.
Date: Wed, 26 Jun 2013 18:10:51 +0200	[thread overview]
Message-ID: <20130626161051.GA8207@gmail.com> (raw)
In-Reply-To: <51CB110E.6010707@gmail.com>


* David Ahern <dsahern@gmail.com> wrote:

> On 6/26/13 9:50 AM, Ingo Molnar wrote:
> >
> >* Peter Zijlstra <peterz@infradead.org> wrote:
> >
> >>On Wed, Jun 26, 2013 at 11:37:13AM +0200, Ingo Molnar wrote:
> >>>Would be very nice to randomize the sampling rate, by randomizing the
> >>>intervals within a 1% range or so - perf tooling will probably recognize
> >>>the different weights.
> >>
> >>You're suggesting adding noise to the regular kernel tick?
> >
> >No, to the perf interval (which I assumed Mike was using to profile this?)
> >- although slightly randomizing the kernel tick might make sense as well,
> >especially if it's hrtimer driven and reprogrammed anyway.
> >
> >I might have gotten it all wrong though ...
> 
> Sampled S/W events like cpu-clock have a fixed rate 
> (perf_swevent_init_hrtimer converts freq to sample_period).
> 
> Sampled H/W events have an adaptive period that converges to the desired 
> sampling rate. The first few samples come in 10 usecs are so apart and 
> the time period expands to the desired rate. As I recall that adaptive 
> algorithm starts over every time the event is scheduled in.

Yes, but last I checked it (2 years ago? :-) the auto-freq code was 
converging pretty well to the time clock, with little jitter - in essence 
turning it into a fixed-period, fixed-frequency sampling method. That 
would explain Mike's results.

Thanks,

	Ingo

  reply	other threads:[~2013-06-26 16:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20 19:46 Scheduler accounting inflated for io bound processes Dave Chiluk
2013-06-25 16:01 ` Mike Galbraith
2013-06-25 17:48   ` Mike Galbraith
2013-06-26  9:37     ` Ingo Molnar
2013-06-26 10:42       ` Peter Zijlstra
2013-06-26 15:50         ` Ingo Molnar
2013-06-26 16:01           ` Mike Galbraith
2013-06-26 16:04           ` David Ahern
2013-06-26 16:10             ` Ingo Molnar [this message]
2013-06-26 16:13               ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130626161051.GA8207@gmail.com \
    --to=mingo@kernel.org \
    --cc=bitbucket@online.de \
    --cc=chiluk@canonical.com \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox